Re: [Qemu-devel] [PATCH v2] qdev: Keep global allocation counter per bus

[Markus Armbruster <armbru@redhat.com>]

Paolo Bonzini <pbonzini@redhat.com> writes:

> Il 21/12/2013 11:42, Markus Armbruster ha scritto:
>> Suggest to add: ", killing migration."
>
> Not good.  But perhaps we can give a reason for this 2.0 thing.
>
> It is certainly nice to schedule incompatible changes for obscure
> machine types every 2 years.
>
>> Which boards are affected?  Should be listed in the commit message!
>> 
>> I ran a quick test for all boards that actually make it to the monitor
>> without special parameters or files, and survive "info qtree".  164
>> boards can do that, 59 refuse to start, one crashes on start, 10 make it
>> to the monitor but crash in info qtree.  Not nice.  If there's a way to
>> start *any* board to the monitor, please let me know.
>
> "-machine accel=qtest" probably helps with those that refuse to start.

Yes, that helps some.

Non-unique bus names:

    target      machine         bus id              times
    aarch64	connex 		dummy		    2
    				i2c		    2
			     	ssi		    2
    aarch64	mainstone	dummy		    2
    				i2c		    2
				ssi		    3
    aarch64	n800		i2c-bus.0	    2
    aarch64	n810		i2c-bus.0	    2
    aarch64	nuri		i2c		    9
    aarch64	smdkc210	i2c		    9
    aarch64	verdex		dummy		    2
    				i2c		    2
				ssi		    3
    aarch64	vexpress-a15	virtio-mmio-bus.0   4
    aarch64	vexpress-a9	virtio-mmio-bus.0   4
    aarch64	virt		virtio-mmio-bus.0   32
    aarch64	xilinx-zynq-a9	spi0		    3
			     	usb-bus.0	    2
    aarch64	z2		dummy		    2
			     	i2c		    2
			     	ssi		    3
    arm		connex		dummy		    2
			     	i2c		    2
			     	ssi		    2
    arm		mainstone	dummy		    2
			     	i2c		    2
			     	ssi		    3
    arm		n800		i2c-bus.0	    2
    arm		n810		i2c-bus.0	    2
    arm		nuri		i2c		    9
    arm		smdkc210	i2c		    9
    arm		verdex		dummy		    2
			     	i2c		    2
			     	ssi		    3
    arm		vexpress-a15	virtio-mmio-bus.0   4
    arm		vexpress-a9	virtio-mmio-bus.0   4
    arm		virt		virtio-mmio-bus.0   32
    arm		xilinx-zynq-a9	spi0		    3
			     	usb-bus.0	    2
    arm		z2		dummy		    2
			     	i2c		    2
			     	ssi		    3
    i386	isapc		ide.0		    2
    mips	mips		ide.0		    2
    mips64	mips		ide.0		    2
    mips64el	fulong2e	usb-bus.0	    2
    mips64el	mips		ide.0		    2
    mipsel	mips		ide.0		    2
    ppc		g3beige		ide.0		    2
    ppc		mac99		ide.0		    2
    ppc		prep		ide.0		    2
    ppc64	g3beige		ide.0		    2
    ppc64	mac99		ide.0		    2
    ppc64	prep		ide.0		    2
    s390x	s390-virtio	virtio-bus	    2
    x86_64	isapc		ide.0		    2

Machines not covered:

    target      machine         reason
    aarch64     akita           info qtree crashes
    aarch64     borzoi          info qtree crashes
    aarch64     spitz           info qtree crashes
    aarch64     terrier         info qtree crashes
    aarch64     tosa            info qtree crashes
    arm         akita           info qtree crashes
    arm         borzoi          info qtree crashes
    arm         spitz           info qtree crashes
    arm         terrier         info qtree crashes
    arm         tosa            info qtree crashes
    cris        axis-dev88      info qtree crashes
    i386        xenfv           refuses to start (1)
    i386        xenpv           refuses to start (2)
    ppcemb      g3beige         refuses to start (3)
    ppcemb      mac99           refuses to start (3)
    ppcemb      mpc8544ds       refuses to start (4)
    ppcemb      ppce500         refuses to start (4)
    ppcemb      prep            refuses to start (3)
    ppcemb      ref405ep        refuses to start (5)
    ppcemb      taihu           refuses to start (5)
    x86_64      xenfv           refuses to start (1)
    x86_64      xenpv           refuses to start (2)

    (1) xen be core: can't connect to xenstored
        Expected, as it's not running under Xen
    (2) Segmentation fault
    (3) Unable to find PowerPC CPU definition
    (4) Unable to initialize CPU!
    (5) Unable to find PowerPC 405ep CPU definition

[...]

>> Patch looks good to me, but I'd recommend more thorough testing, as
>> outlined above.

Still do.