From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42731)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1VdmlS-0004od-0Y
	for qemu-devel@nongnu.org; Tue, 05 Nov 2013 14:58:21 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1VdmlK-0006Vi-Nf
	for qemu-devel@nongnu.org; Tue, 05 Nov 2013 14:58:13 -0500
Received: from mail-pb0-f52.google.com ([209.85.160.52]:45345)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1VdmlK-0006VS-Hb
	for qemu-devel@nongnu.org; Tue, 05 Nov 2013 14:58:06 -0500
Received: by mail-pb0-f52.google.com with SMTP id rr4so1448132pbb.25
	for <qemu-devel@nongnu.org>; Tue, 05 Nov 2013 11:58:05 -0800 (PST)
From: Anthony Liguori <anthony@codemonkey.ws>
In-Reply-To: <1383558557.8610.23.camel@nilsson.home.kraxel.org>
References: <1383497154-9271-1-git-send-email-aliguori@amazon.com>
	<1383558557.8610.23.camel@nilsson.home.kraxel.org>
Date: Tue, 05 Nov 2013 11:57:57 -0800
Message-ID: <87k3gmwri2.fsf@codemonkey.ws>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: Re: [Qemu-devel] [PATCH] ossaudio: do not enable by default
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org, Anthony Liguori <aliguori@amazon.com>, Andreas Faerber <afaerber@suse.de>

Gerd Hoffmann <kraxel@redhat.com> writes:

> On So, 2013-11-03 at 08:45 -0800, Anthony Liguori wrote:
>> Modern Linux's no longer support /dev/dsp so enabling it by
>> default causes audio failures on newer Linux distros.
>
> That will break sound on BSD.
>
> I think we should do something like this instead:
>
> --- a/configure
> +++ b/configure
> @@ -554,7 +554,7 @@ Haiku)
>    LIBS="-lposix_error_mapper -lnetwork $LIBS"
>  ;;
>  *)
> -  audio_drv_list="oss"
> +  audio_drv_list="pa alsa oss"
>    audio_possible_drivers="oss alsa sdl esd pa"
>    linux="yes"
>    linux_user="yes"
>
> i.e. build pulseaudio and alsa by default on linux and prioritize them
> over oss.

This patch just requires that you explicitly select oss so it's not
breaking audio on BSD.

Since the oss code can fail to initialize without handling it
gracefully, it really cannot be default on any platform.

Same problem would occur on BSD if the permissions on /dev/dsp were
restrictive.

Regards,

Anthony Liguori

>
> cheers,
>   Gerd