From: Jani Nikula <jani.nikula@linux.intel.com>
To: Daniel Vetter <daniel@ffwll.ch>, dl9pf@gmx.de
Cc: airlied@linux.ie, daniel.vetter@ffwll.ch,
intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, pageexec@freemail.hu
Subject: Re: [Intel-gfx] [PATCH] [TRIVIAL] Fix declaration of intel_gmbus_{is_forced_bit/is_port_falid} in i915 driver.
Date: Fri, 03 May 2013 15:03:37 +0300 [thread overview]
Message-ID: <87k3ngtgme.fsf@intel.com> (raw)
In-Reply-To: <20130503092348.GL5763@phenom.ffwll.local>
On Fri, 03 May 2013, Daniel Vetter <daniel@ffwll.ch> wrote:
> On Fri, May 03, 2013 at 11:17:42AM +0200, dl9pf@gmx.de wrote:
>> From: Jan-Simon Möller <dl9pf@gmx.de>
>>
>> Description:
>> intel_gmbus_is_forced_bit is no extern as its body is right below.
>> Likewise for intel_gmbus_is_port_valid.
>>
>> This fixes a compilation issue with clang. An initial version of this patch
>> was developed by PaX Team <pageexec at freemail.hu>.
>> This is respin of this patch.
>>
>> Signed-off-by: Jan-Simon Möller <dl9pf@gmx.de>
>> CC: pageexec@freemail.hu
>> CC: daniel.vetter@ffwll.ch
>> CC: airlied@linux.ie
>> CC: intel-gfx@lists.freedesktop.org
>> CC: dri-devel@lists.freedesktop.org
>> CC: linux-kernel@vger.kernel.org
> Picked up for -fixes, thanks for the patch.
Please drop it.
The patch removes the inline keyword, creating dozens of copies of the
functions, and consequently loads of warnings:
drivers/gpu/drm/i915/i915_drv.h:1803:13: warning: ‘intel_gmbus_is_port_valid’ defined but not used [-Wunused-function]
drivers/gpu/drm/i915/i915_drv.h:1812:13: warning: ‘intel_gmbus_is_forced_bit’ defined but not used [-Wunused-function]
BR,
Jani.
next prev parent reply other threads:[~2013-05-03 12:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-03 9:17 [PATCH] [TRIVIAL] Fix declaration of intel_gmbus_{is_forced_bit/is_port_falid} in i915 driver dl9pf
2013-05-03 9:23 ` Daniel Vetter
2013-05-03 12:03 ` Jani Nikula [this message]
2013-05-03 16:16 ` [Intel-gfx] " Daniel Vetter
2013-05-04 8:55 ` PaX Team
2013-05-06 12:46 ` Jan-Simon Möller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k3ngtgme.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=airlied@linux.ie \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel@ffwll.ch \
--cc=dl9pf@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pageexec@freemail.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.