From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [Intel-gfx] [PATCH] [TRIVIAL] Fix declaration of intel_gmbus_{is_forced_bit/is_port_falid} in i915 driver. Date: Fri, 03 May 2013 15:03:37 +0300 Message-ID: <87k3ngtgme.fsf@intel.com> References: <1367572662-18400-1-git-send-email-dl9pf@gmx.de> <20130503092348.GL5763@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <20130503092348.GL5763@phenom.ffwll.local> Sender: linux-kernel-owner@vger.kernel.org To: Daniel Vetter , dl9pf@gmx.de Cc: airlied@linux.ie, daniel.vetter@ffwll.ch, intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, pageexec@freemail.hu List-Id: dri-devel@lists.freedesktop.org On Fri, 03 May 2013, Daniel Vetter wrote: > On Fri, May 03, 2013 at 11:17:42AM +0200, dl9pf@gmx.de wrote: >> From: Jan-Simon M=C3=B6ller >>=20 >> Description: >> intel_gmbus_is_forced_bit is no extern as its body is right below. >> Likewise for intel_gmbus_is_port_valid. >>=20 >> This fixes a compilation issue with clang. An initial version of thi= s patch >> was developed by PaX Team . >> This is respin of this patch. >>=20 >> Signed-off-by: Jan-Simon M=C3=B6ller >> CC: pageexec@freemail.hu >> CC: daniel.vetter@ffwll.ch >> CC: airlied@linux.ie >> CC: intel-gfx@lists.freedesktop.org >> CC: dri-devel@lists.freedesktop.org >> CC: linux-kernel@vger.kernel.org > Picked up for -fixes, thanks for the patch. Please drop it. The patch removes the inline keyword, creating dozens of copies of the functions, and consequently loads of warnings: drivers/gpu/drm/i915/i915_drv.h:1803:13: warning: =E2=80=98intel_gmbus_= is_port_valid=E2=80=99 defined but not used [-Wunused-function] drivers/gpu/drm/i915/i915_drv.h:1812:13: warning: =E2=80=98intel_gmbus_= is_forced_bit=E2=80=99 defined but not used [-Wunused-function] BR, Jani.