From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH 3/6] drm/i915: Use DEV_INFO_FOR_EACH_FLAG() to declare flags as well Date: Tue, 23 Apr 2013 10:25:23 +0300 Message-ID: <87k3ntzp24.fsf@intel.com> References: <1366652441-2511-1-git-send-email-damien.lespiau@intel.com> <1366652441-2511-4-git-send-email-damien.lespiau@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id B06A6E605F for ; Tue, 23 Apr 2013 00:27:47 -0700 (PDT) In-Reply-To: <1366652441-2511-4-git-send-email-damien.lespiau@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Damien Lespiau , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Mon, 22 Apr 2013, Damien Lespiau wrote: > Signed-off-by: Damien Lespiau Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/i915/i915_drv.h | 31 +++++++------------------------ > 1 file changed, 7 insertions(+), 24 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h > index 725d53d..4239263 100644 > --- a/drivers/gpu/drm/i915/i915_drv.h > +++ b/drivers/gpu/drm/i915/i915_drv.h > @@ -359,36 +359,19 @@ struct drm_i915_gt_funcs { > func(has_blt_ring) sep \ > func(has_llc) > > +#define DEFINE_FLAG(name) u8 name:1 > +#define SEP_SEMICOLON ; > + > struct intel_device_info { > u32 display_mmio_offset; > u8 num_pipes:3; > u8 gen; > - u8 is_mobile:1; > - u8 is_i85x:1; > - u8 is_i915g:1; > - u8 is_i945gm:1; > - u8 is_g33:1; > - u8 need_gfx_hws:1; > - u8 is_g4x:1; > - u8 is_pineview:1; > - u8 is_broadwater:1; > - u8 is_crestline:1; > - u8 is_ivybridge:1; > - u8 is_valleyview:1; > - u8 has_force_wake:1; > - u8 is_haswell:1; > - u8 has_fbc:1; > - u8 has_pipe_cxsr:1; > - u8 has_hotplug:1; > - u8 cursor_needs_physical:1; > - u8 has_overlay:1; > - u8 overlay_needs_physical:1; > - u8 supports_tv:1; > - u8 has_bsd_ring:1; > - u8 has_blt_ring:1; > - u8 has_llc:1; > + DEV_INFO_FOR_EACH_FLAG(DEFINE_FLAG, SEP_SEMICOLON); > }; > > +#undef DEFINE_FLAG > +#undef SEP_SEMICOLON > + > enum i915_cache_level { > I915_CACHE_NONE = 0, > I915_CACHE_LLC, > -- > 1.8.1.4 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx