From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Subject: Re: [PATCH 2/2] drm/i915: Don't default to overclock max
Date: Tue, 09 Apr 2013 16:44:28 +0300
Message-ID: <87k3obyg1v.fsf@gaia.fi.intel.com>
References: <CAKMK7uFc4EuJUEEPB_hCA_ygsTagXKFUEB6W1+aJKZ8Mma_Gag@mail.gmail.com>
	<1365197363-10218-1-git-send-email-ben@bwidawsk.net>
	<1365197363-10218-2-git-send-email-ben@bwidawsk.net>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mga14.intel.com (mga14.intel.com [143.182.124.37])
	by gabe.freedesktop.org (Postfix) with ESMTP id 56112E6141
	for <intel-gfx@lists.freedesktop.org>;
	Tue,  9 Apr 2013 06:44:55 -0700 (PDT)
In-Reply-To: <1365197363-10218-2-git-send-email-ben@bwidawsk.net>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: intel-gfx@lists.freedesktop.org
Cc: Ben Widawsky <ben@bwidawsk.net>
List-Id: intel-gfx@lists.freedesktop.org

Ben Widawsky <ben@bwidawsk.net> writes:

> Requested-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
> ---
>  drivers/gpu/drm/i915/intel_pm.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index 2edb743..c81921b 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -2632,11 +2632,10 @@ static void gen6_enable_rps(struct drm_device *dev)
>  		pcu_mbox = 0;
>  		ret = sandybridge_pcode_read(dev_priv, GEN6_READ_OC_PARAMS, &pcu_mbox);
>  		if (!ret && (pcu_mbox & (1<<31))) { /* OC supported */
> -			DRM_DEBUG_DRIVER("overclocking supported, adjusting frequency max from %dMHz to %dMHz\n",
> +			DRM_DEBUG_DRIVER("Overclocking supported. Max: %dMHz, Overclock max: %dMHz\n",
>  					 (dev_priv->rps.max_delay & 0xff) * 50,
>  					 (pcu_mbox & 0xff) * 50);
Minor nitpick:                                              
Use GT_FREQUENCY_MULTIPLIER instead of 50

>  			dev_priv->rps.hw_max = pcu_mbox & 0xff;
> -			dev_priv->rps.max_delay = pcu_mbox & 0xff;
>  		}
>  	} else {
>  		DRM_DEBUG_DRIVER("Failed to set the min frequency\n");
> -- 
> 1.8.2

Reviewed-by: Mika Kuoppala <mika.kuoppala@intel.com>