All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: sjur.brandeland@stericsson.com, mst@redhat.com
Cc: virtualization@lists.linux-foundation.org
Subject: [PATCH 0/6] virtio_add_buf replacement.
Date: Wed, 06 Mar 2013 16:15:02 +1100	[thread overview]
Message-ID: <87k3plaz3d.fsf@rustcorp.com.au> (raw)

OK, so I've spent a few days benchmarking.  Turns out 80% of
virtio_add_buf cases are uni-directional (including the
always-performance-sensitive networking code), and that gets no
performance penalty (though tests with real networking would be
appreciated!).

I'm not reposting all the "convert driver to virtio_add_outbuf()"
patches: just the scsi one which I didn't have before.  I won't actually
remove virtio_add_buf() until the *following* merge window, just to be
sure.

One annoying thing about benchmarking is that in some cases, speeding up
one side can make the whole thing slower, due to more wakeups.
Device-side polling techniques might be required in future to get more
performance.

Cheers,
Rusty.

             reply	other threads:[~2013-03-06  5:15 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-06  5:15 Rusty Russell [this message]
2013-03-06  5:19 ` [PATCH 1/6] virtio_ring: virtqueue_add_sgs, to add multiple sgs Rusty Russell
2013-03-06  5:19 ` Rusty Russell
2013-03-06  5:20 ` [PATCH 2/6] virtio_ring: don't count elements twice for add_buf path Rusty Russell
2013-03-06  5:22 ` [PATCH 3/6] virtio_ring: inline internal vring functions more aggressively Rusty Russell
2013-03-06 10:24   ` Michael S. Tsirkin
2013-03-06 23:02     ` Rusty Russell
2013-03-06  5:23 ` [PATCH 4/6] virtio_ring: virtqueue_add_outbuf / virtqueue_add_inbuf Rusty Russell
2013-03-06  8:37   ` Asias He
2013-03-07  0:33     ` Rusty Russell
2013-03-07  8:15       ` Asias He
2013-03-06  5:24 ` [PATCH 5/6] tools/virtio: make vringh_test use inbuf/outbuf Rusty Russell
2013-03-06  5:24 ` [PATCH 6/6] virtio_scsi: use virtqueue_add_inbuf() for virtscsi_kick_event Rusty Russell
2013-03-06  8:09 ` [PATCH 0/6] virtio_add_buf replacement Asias He
2013-03-07  0:35   ` Rusty Russell
2013-03-07  8:22     ` Asias He

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k3plaz3d.fsf@rustcorp.com.au \
    --to=rusty@rustcorp.com.au \
    --cc=mst@redhat.com \
    --cc=sjur.brandeland@stericsson.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.