Re: [PATCH -next] [SCSI] mpt3sas: remove unused variables

["Bjørn Mork" <bjorn@mork.no>]

<sreekanth.reddy@lsi.com> writes:

> diff --git a/drivers/scsi/mpt3sas/mpt3sas_scsih.c b/drivers/scsi/mpt3sas/mpt3sas_scsih.c
> index ac9dbc2..61a1a45 100644
> --- a/drivers/scsi/mpt3sas/mpt3sas_scsih.c
> +++ b/drivers/scsi/mpt3sas/mpt3sas_scsih.c
> @@ -2754,13 +2754,11 @@ _scsih_block_io_to_children_attached_directly(struct MPT3SAS_ADAPTER *ioc,
>  	int i;
>  	u16 handle;
>  	u16 reason_code;
> -	u8 phy_number;
>  
>  	for (i = 0; i < event_data->NumEntries; i++) {
>  		handle = le16_to_cpu(event_data->PHY[i].AttachedDevHandle);
>  		if (!handle)
>  			continue;
> -		phy_number = event_data->StartPhyNum + i;
>  		reason_code = event_data->PHY[i].PhyStatus &
>  		    MPI2_EVENT_SAS_TOPO_RC_MASK;
>  		if (reason_code == MPI2_EVENT_SAS_TOPO_RC_DELAY_NOT_RESPONDING)

There is an identical copy of this code, including that bug, in
drivers/scsi/mpt2sas/mpt2sas_scsih.c.

If you insist on the stupid code duplication, then please try to keep
your bugs syncronized!  If you are going to fix this bug for the mpt3sas
driver, then you *have* to fix it for mpt2sas as well.

Yes, I believe this is a mess and you have already demonstrated that you
are incapable of managing it.


Bjørn
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html