From: ebiederm@xmission.com (Eric W. Biederman)
To: Tommi Rantala <tt.rantala@gmail.com>
Cc: netdev@vger.kernel.org, Neil Horman <nhorman@tuxdriver.com>,
Vlad Yasevich <vyasevich@gmail.com>,
Sridhar Samudrala <sri@us.ibm.com>,
"David S. Miller" <davem@davemloft.net>,
linux-sctp@vger.kernel.org, Dave Jones <davej@redhat.com>
Subject: Re: [PATCHv2] sctp: fix /proc/net/sctp/ memory leak
Date: Thu, 15 Nov 2012 21:48:43 +0000 [thread overview]
Message-ID: <87k3tmedvo.fsf@xmission.com> (raw)
In-Reply-To: <1352987345-11263-1-git-send-email-tt.rantala@gmail.com> (Tommi Rantala's message of "Thu, 15 Nov 2012 15:49:05 +0200")
Tommi Rantala <tt.rantala@gmail.com> writes:
> Commit 13d782f ("sctp: Make the proc files per network namespace.")
> changed the /proc/net/sctp/ struct file_operations opener functions to
> use single_open_net() and seq_open_net().
>
> Avoid leaking memory by using single_release_net() and seq_release_net()
> as the release functions.
>
> Discovered with Trinity (the syscall fuzzer).
Doh! Thanks for catching this.
Eric
> - .release = single_release,
> + .release = single_release_net,
> };
> - .release = seq_release,
> + .release = seq_release_net,
> };
>
prev parent reply other threads:[~2012-11-15 21:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-15 13:49 [PATCHv2] sctp: fix /proc/net/sctp/ memory leak Tommi Rantala
2012-11-15 18:56 ` David Miller
2012-11-15 21:48 ` Eric W. Biederman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k3tmedvo.fsf@xmission.com \
--to=ebiederm@xmission.com \
--cc=davej@redhat.com \
--cc=davem@davemloft.net \
--cc=linux-sctp@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=sri@us.ibm.com \
--cc=tt.rantala@gmail.com \
--cc=vyasevich@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.