Re: [Qemu-devel] [PULL 00/29] qemu-sockets error propagation + NBD server

[Anthony Liguori <aliguori@us.ibm.com>]

Paolo Bonzini <pbonzini@redhat.com> writes:

> Anthony,
>
> The following changes since commit b6348f29d033d5a8a26f633d2ee94362595f32a4:
>
>   target-arm/translate: Fix RRX operands (2012-10-17 19:56:46 +0200)
>
> are available in the git repository at:
>
>   git://github.com/bonzini/qemu.git nbd-next
>
> for you to fetch changes up to 1f493f2c7ee75691c4ad22a7663f908924f464c5:
>
>   qmp: add NBD server commands (2012-10-19 15:29:12 +0200)
>
> I and Luiz agreed that I would take care of sending it to you.  It's been
> through his and Markus's review, and in particularly Markus suggested
> various improvements to the commit message and further splitting of
> some commits; the only remaining sore point was the HMP interface so I
> dropped it for now.

anthony@titi:~/build/qemu$ make
  GEN   qmp-commands.h
  GEN   qapi-types.h
  GEN   qapi-visit.h
  GEN   QMP/qmp-commands.txt
  CC    osdep.o
  CC    oslib-posix.o
  CC    trace.o
  CC    trace/default.o
  CC    trace/control.o
  CC    qemu-tool.o
  CC    qemu-timer.o
  CC    main-loop.o
  CC    iohandler.o
  CC    cutils.o
  CC    async.o
  CC    libcacard/vscclient.o
  LINK  vscclient
qemu-tool.o: In function `monitor_get_fd':
/home/anthony/git/qemu/qemu-tool.c:53: undefined reference to `error_set'
collect2: ld returned 1 exit status
make: *** [vscclient] Error 1

Even tried a clean build and get the same error.

Regards,

Anthony Liguori

>
> Paolo
>
> ----------------------------------------------------------------
> Paolo Bonzini (29):
>       error: add error_set_errno and error_setg_errno
>       qemu-sockets: add Error ** to all functions
>       qemu-sockets: unix_listen and unix_connect are portable
>       qemu-sockets: add nonblocking connect for Unix sockets
>       migration: avoid using error_is_set and thus relying on errp != NULL
>       migration: centralize call to migrate_fd_error()
>       migration: use qemu-sockets to establish Unix sockets
>       migration (outgoing): add error propagation for all protocols
>       migration (incoming): add error propagation to fd and exec protocols
>       qemu-char: ask and print error information from qemu-sockets
>       nbd: ask and print error information from qemu-sockets
>       qemu-ga: ask and print error information from qemu-sockets
>       vnc: avoid Yoda conditionals
>       vnc: introduce a single label for error returns
>       vnc: reorganize code for reverse mode
>       vnc: add error propagation to vnc_display_open
>       qemu-sockets: include strerror or gai_strerror output in error messages
>       qemu-sockets: add error propagation to inet_connect_addr
>       qemu-sockets: add error propagation to inet_dgram_opts
>       qemu-sockets: add error propagation to inet_parse
>       qemu-sockets: add error propagation to Unix socket functions
>       vnc: drop QERR_VNC_SERVER_FAILED
>       build: add QAPI files to the tools
>       qapi: add socket address types
>       qemu-sockets: return InetSocketAddress from inet_parse
>       qemu-sockets: add socket_listen, socket_connect, socket_parse
>       block: prepare code for adding block notifiers
>       block: add close notifiers
>       qmp: add NBD server commands
>
>  Makefile.objs       |   9 +-
>  block.c             |  19 ++-
>  block.h             |   1 +
>  block_int.h         |   2 +
>  blockdev-nbd.c      | 119 +++++++++++++++
>  console.h           |   2 +-
>  error.c             |  28 ++++
>  error.h             |   9 ++
>  migration-exec.c    |  26 +---
>  migration-fd.c      |  27 +---
>  migration-tcp.c     |  19 +--
>  migration-unix.c    |  95 ++----------
>  migration.c         |  34 ++---
>  migration.h         |  19 ++-
>  nbd.c               |  39 ++++-
>  qapi-schema.json    |  96 ++++++++++++
>  qemu-char.c         |  24 ++-
>  qemu-sockets.c      | 424 ++++++++++++++++++++++++++++++++++------------------
>  qemu-tool.c         |   6 +
>  qemu_socket.h       |  19 ++-
>  qerror.h            |   3 -
>  qga/channel-posix.c |   8 +-
>  qmp-commands.hx     |  16 ++
>  qmp.c               |   6 +-
>  ui/vnc.c            |  93 ++++++------
>  vl.c                |  25 ++--
>  26 file modificati, 756 inserzioni(+), 412 rimozioni(-)
>  create mode 100644 blockdev-nbd.c
> -- 
> 1.7.12.1