From: Anthony Liguori <aliguori@us.ibm.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
Alex Williamson <alex.williamson@redhat.com>
Cc: Alex Barcelo <abarcelo@ac.upc.edu>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] vfio_pci: fix build on 32-bit systems
Date: Tue, 02 Oct 2012 10:03:19 -0500 [thread overview]
Message-ID: <87k3v89ars.fsf@codemonkey.ws> (raw)
In-Reply-To: <506A8591.9040306@redhat.com>
Paolo Bonzini <pbonzini@redhat.com> writes:
> Il 01/10/2012 20:49, Alex Williamson ha scritto:
>>> > @@ -768,7 +768,7 @@ static int vfio_dma_map(VFIOContainer *container, target_phys_addr_t iova,
>>> > struct vfio_iommu_type1_dma_map map = {
>>> > .argsz = sizeof(map),
>>> > .flags = VFIO_DMA_MAP_FLAG_READ,
>>> > - .vaddr = (__u64)vaddr,
>>> > + .vaddr = (__u64)(intptr_t)vaddr,
>
> Does this need to be uintptr_t?
I don't think it matters semantically but using uintptr_t can't hurt.
Regards,
Anthony Liguori
>
> Paolo
>
>>> > .iova = iova,
>>> > .size = size,
>>> > };
>> Thanks Anthony
>>
>> Acked-by: Alex Williamson <alex.williamson@redhat.com>
next prev parent reply other threads:[~2012-10-02 15:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-01 18:41 [Qemu-devel] [PATCH] vfio_pci: fix build on 32-bit systems Anthony Liguori
2012-10-01 18:49 ` Alex Williamson
2012-10-02 6:11 ` Paolo Bonzini
2012-10-02 14:37 ` Alex Williamson
2012-10-02 15:03 ` Anthony Liguori [this message]
2012-10-01 19:27 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k3v89ars.fsf@codemonkey.ws \
--to=aliguori@us.ibm.com \
--cc=abarcelo@ac.upc.edu \
--cc=alex.williamson@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.