From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:48736) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T9OVh-0003bt-0U for qemu-devel@nongnu.org; Wed, 05 Sep 2012 18:55:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T9OVf-0005Qm-MW for qemu-devel@nongnu.org; Wed, 05 Sep 2012 18:55:48 -0400 Received: from e38.co.us.ibm.com ([32.97.110.159]:50299) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T9OVf-0005Qi-C3 for qemu-devel@nongnu.org; Wed, 05 Sep 2012 18:55:47 -0400 Received: from /spool/local by e38.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 5 Sep 2012 16:55:46 -0600 Received: from d03relay01.boulder.ibm.com (d03relay01.boulder.ibm.com [9.17.195.226]) by d03dlp02.boulder.ibm.com (Postfix) with ESMTP id 588243E40045 for ; Wed, 5 Sep 2012 16:55:43 -0600 (MDT) Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168]) by d03relay01.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q85MtfZf222680 for ; Wed, 5 Sep 2012 16:55:42 -0600 Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1]) by d03av02.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q85Mtfft018135 for ; Wed, 5 Sep 2012 16:55:41 -0600 From: Anthony Liguori In-Reply-To: <5047B9F3.2000507@web.de> References: <1346872724-9156-1-git-send-email-aliguori@us.ibm.com> <1346872724-9156-3-git-send-email-aliguori@us.ibm.com> <5047B046.6040503@weilnetz.de> <5047B9F3.2000507@web.de> Date: Wed, 05 Sep 2012 17:55:34 -0500 Message-ID: <87k3w8nkpl.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [PATCH 2/7] ui: add basic GTK gui (v2) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka , Stefan Weil Cc: qemu-devel@nongnu.org Jan Kiszka writes: > On 2012-09-05 22:04, Stefan Weil wrote: >> Am 05.09.2012 21:18, schrieb Anthony Liguori: >>> This is minimalistic and just contains the basic widget >>> infrastructure. The GUI >>> consists of a menu and a GtkNotebook. To start with, the notebook has >>> its tabs >>> hidden which provides a UI that looks very similar to SDL with the >>> exception of >>> the menu bar. >>> >>> The menu bar allows a user to toggle the visibility of the tabs. >>> Cairo is used >>> for rendering. >>> >>> I used gtk-vnc as a reference. gtk-vnc solves the same basic problems >>> as QEMU >>> since it was originally written as a remote display for QEMU. So for >>> the most >>> part, the approach to rendering and keyboard handling should be pretty >>> solid for >>> GTK. >>> >>> Signed-off-by: Anthony Liguori >>> --- >>> v1 -> v2 >>> - add gtk-vnc license >>> - fix key propagation >>> --- >>> Makefile | 2 + >>> configure | 25 +++- >>> console.h | 4 + >>> sysemu.h | 1 + >>> ui/Makefile.objs | 1 + >>> ui/gtk.c | 572 >>> ++++++++++++++++++++++++++++++++++++++++++++++++++++++ >>> 6 files changed, 604 insertions(+), 1 deletions(-) >>> create mode 100644 ui/gtk.c >>> >> >> Hi Anthony, >> >> I tested the previous version of your series and noticed that the >> menu accelerators (especially for file/quit) which are still part of >> this new patch are a bad idea. >> >> Just run a system emulation, start some GUI program in the emulation >> and press Ctrl-Q: you won't terminate the GUI program, but terminate >> QEMU! > > Yep, standard accelerators must go, definitely while the input is > grabbed. I finally figured out how to do this in GTK so I can limit the number of accelerators that are active while keyboard grab is active. It'll be a part of v4. Regards, Anthony Liguori > > Jan