From: Ben Pfaff <blp@cs.stanford.edu>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Add kabs()
Date: Wed, 25 Apr 2012 10:20:48 -0700 [thread overview]
Message-ID: <87k413pw27.fsf@blp.benpfaff.org> (raw)
In-Reply-To: <20120423131106.GA27574@p183.telecom.by> (Alexey Dobriyan's message of "Mon, 23 Apr 2012 16:11:06 +0300")
Alexey Dobriyan <adobriyan@gmail.com> writes:
> kabs() has the following nice properties which should have been there
> from day 1.
>
> kabs() return unsigned value.
> kabs() works for all integer types and return correct result.
> sizeof(kabs(x)) == sizeof(x)
It would be nice to document these properties in a source code
comment, as well as in the commit message.
prev parent reply other threads:[~2012-04-25 17:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-23 13:11 [PATCH] Add kabs() Alexey Dobriyan
2012-04-23 13:22 ` [PATCH v2] " Alexey Dobriyan
2012-04-23 18:18 ` Nick Bowler
2012-04-25 17:20 ` Ben Pfaff [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k413pw27.fsf@blp.benpfaff.org \
--to=blp@cs.stanford.edu \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.