All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] Don't use host gcc use target tools.(signed-off this time)
Date: Sun, 11 Dec 2011 23:18:00 +0100	[thread overview]
Message-ID: <87k462bvmv.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <1323513989-8594-1-git-send-email-sagaert.johan@skynet.be> (Sagaert Johan's message of "Sat, 10 Dec 2011 11:46:29 +0100")

>>>>> "Sagaert" == Sagaert Johan <sagaert.johan@skynet.be> writes:

Please don't add comments like that in the subject, as that goes in the
final commit message - Rather put it after the '---' line and before the
patch.

 Sagaert> Signed-off-by: Sagaert Johan <sagaert.johan@skynet.be>


 Sagaert> ---
 Sagaert>  package/libcgi/libcgi.mk |    2 ++
 Sagaert>  1 files changed, 2 insertions(+), 0 deletions(-)

 Sagaert> diff --git a/package/libcgi/libcgi.mk b/package/libcgi/libcgi.mk
 Sagaert> index 5867ff9..e70be80 100644
 Sagaert> --- a/package/libcgi/libcgi.mk
 Sagaert> +++ b/package/libcgi/libcgi.mk
 Sagaert> @@ -7,5 +7,7 @@ LIBCGI_VERSION:=1.0
 Sagaert>  LIBCGI_SOURCE:=libcgi-$(LIBCGI_VERSION).tar.gz
 Sagaert>  LIBCGI_SITE:=http://$(BR2_SOURCEFORGE_MIRROR).dl.sourceforge.net/sourceforge/libcgi
 Sagaert>  LIBCGI_INSTALL_STAGING=YES
 Sagaert> +#Don't use host compiler
 Sagaert> +LIBCGI_MAKE_ENV = CC="$(TARGET_CC)"  AR="$(TARGET_AR)"

We should also pass TARGET_CFLAGS, to ensure the right compiler flags
are used.

I fixed that up and cleaned up some whitespace issues while I was at it
and committed, thanks.

-- 
Bye, Peter Korsgaard

      reply	other threads:[~2011-12-11 22:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-10 10:46 [Buildroot] [PATCH 1/1] Don't use host gcc use target tools.(signed-off this time) Sagaert Johan
2011-12-11 22:18 ` Peter Korsgaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k462bvmv.fsf@macbook.be.48ers.dk \
    --to=jacmet@uclibc.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.