All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] Add Transmission package
Date: Thu, 17 Nov 2011 21:03:05 +0100	[thread overview]
Message-ID: <87k46ya552.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <1318432931-13347-1-git-send-email-maxime.ripard@free-electrons.com> (Maxime Ripard's message of "Wed, 12 Oct 2011 17:22:11 +0200")

>>>>> "Maxime" == Maxime Ripard <maxime.ripard@free-electrons.com> writes:

 Maxime> From: Maxime Ripard <maxime@free-electrons.com>
 Maxime> Initial work by marcus.osdoba at googlemail.com

Committed with minor comments (see below) to next, thanks.

 Maxime> +++ b/package/transmission/Config.in
 Maxime> @@ -0,0 +1,35 @@
 Maxime> +config BR2_PACKAGE_TRANSMISSION
 Maxime> +	bool "transmission"
 Maxime> +	depends on BR2_INET_IPV6
 Maxime> +	select BR2_PACKAGE_ZLIB
 Maxime> +	select BR2_PACKAGE_OPENSSL
 Maxime> +	select BR2_PACKAGE_LIBCURL
 Maxime> +	select BR2_PACKAGE_LIBEVENT
 Maxime> +	help
 Maxime> +	  Transmission is a cross-platform BitTorrent client.
 Maxime> +
 Maxime> +comment "Transmission requires a toolchain with IPv6 support"
 Maxime> +	depends on !BR2_INET_IPV6
 Maxime> +

This comment should go to the end of the file, otherwise the sub options
don't get indented under the main transmission option in menuconfig.

 Maxime> +++ b/package/transmission/transmission.mk
 Maxime> @@ -0,0 +1,47 @@
 Maxime> +#############################################################
 Maxime> +#
 Maxime> +# transmission
 Maxime> +#
 Maxime> +#############################################################
 Maxime> +TRANSMISSION_VERSION = 2.33
 Maxime> +TRANSMISSION_SITE = http://download.transmissionbt.com/files/
 Maxime> +TRANSMISSION_SOURCE = transmission-$(TRANSMISSION_VERSION).tar.bz2
 Maxime> +TRANSMISSION_DEPENDENCIES = \
 Maxime> +	host-pkg-config \
 Maxime> +	libcurl \
 Maxime> +	libevent \
 Maxime> +	openssl \
 Maxime> +	zlib
 Maxime> +
 Maxime> +TRANSMISSION_CONF_OPT = \
 Maxime> +	--disable-gtk \
 Maxime> +	--disable-libnotify \
 Maxime> +	--enable-lightweight
 Maxime> +
 Maxime> +define TRANSMISSION_INIT_SCRIPT_INSTALL
 Maxime> +	[ -f $(TARGET_DIR)/etc/init.d/S92transmission ] || \
 Maxime> +		$(INSTALL) -m 0755 -D package/transmission/S92transmission \
 Maxime> +			$(TARGET_DIR)/etc/init.d/S92transmission
 Maxime> +endef
 Maxime> +
 Maxime> +ifeq ($(BR2_PACKAGE_TRANSMISSION_UTP),y)
 Maxime> +	TRANSMISSION_CONF_OPT += --enable-utp
 Maxime> +else
 Maxime> +	TRANSMISSION_CONF_OPT += --disable-utp
 Maxime> +endif
 Maxime> +
 Maxime> +ifeq ($(BR2_PACKAGE_TRANSMISSION_CLI),y)
 Maxime> +	TRANSMISSION_CONF_OPT += --enable-cli
 Maxime> +else
 Maxime> +	TRANSMISSION_CONF_OPT += --disable-cli
 Maxime> +endif
 Maxime> +
 Maxime> +
 Maxime> +ifeq ($(BR2_PACKAGE_TRANSMISSION_REMOTE),y)
 Maxime> +	TRANSMISSION_CONF_OPT += --enable-remote
 Maxime> +else
 Maxime> +	TRANSMISSION_CONF_OPT += --disable-remote
 Maxime> +	TRANSMISSION_POST_INSTALL_TARGET_HOOKS += TRANSMISSION_INIT_SCRIPT_INSTALL

I don't see the connection between transmission-remote and the the init
script for transmission-daemon? I've instead added a TRANSMISSION_DAEMON
option, and only install the init script if that is enabled instead.

-- 
Bye, Peter Korsgaard

  parent reply	other threads:[~2011-11-17 20:03 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-03 10:10 [Buildroot] [pull request v2] Pull request for branch for-2011.11/packages Maxime Ripard
2011-10-03 10:10 ` [Buildroot] [PATCH 1/4] Add the picocom package Maxime Ripard
2011-10-05 19:51   ` Peter Korsgaard
2011-10-03 10:10 ` [Buildroot] [PATCH 2/4] Add Transmission package Maxime Ripard
2011-10-05 20:01   ` Peter Korsgaard
2011-10-07 12:34     ` Maxime Ripard
2011-10-12 15:22   ` [Buildroot] [PATCH] " Maxime Ripard
2011-11-14 12:17     ` Maxime Ripard
2011-11-17 20:03     ` Peter Korsgaard [this message]
2011-10-03 10:10 ` [Buildroot] [PATCH 3/4] Add lame support in gstreamer Maxime Ripard
2011-10-05 20:02   ` Peter Korsgaard
2011-10-03 10:10 ` [Buildroot] [PATCH 4/4] Add the libplayer package Maxime Ripard
2011-10-05 20:16   ` Peter Korsgaard
2011-10-06  8:19     ` Thomas Petazzoni
2011-10-06  8:47       ` Peter Korsgaard
2011-10-06  9:08   ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k46ya552.fsf@macbook.be.48ers.dk \
    --to=jacmet@uclibc.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.