Re: [PATCH] arm:omap:serial:cleanup: use module rev instead of cpu_is_xxxx

[Kevin Hilman <khilman@ti.com>]

Vaibhav Hiremath <hvaibhav@ti.com> writes:

> For OMAP3 uarts (module rev >= 0x52) and all successor devices
> (omap4, TI81xx, AM33xx, etc...) empty fifo read errata is applicable,
> so we can get rid of cpu_is_xxxx check and simply check for module rev here.
>
> Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com>
> ---
> NOTE: This patch has been tested on OMAP3EVM, and I expect to work on all OMAP3
> family of devices (including TI816x, TI814x, AM335x, etc...).
> but I am quite not sure about OMAP2 device, can anybody comment/test?

Leaving OMAP2 as it is should be fine.

There is a major UART cleanup in progress from Govindraj.  I suggest you
rework this patch on top of his series from 10/18:

       [PATCH v7 00/21] OMAP2+: UART: Runtime adaptation + cleanup

although it still has a few changes to go through before being ready to
merge.

Kevin