From: Eric Anholt <eric@anholt.net>
To: Jesse Barnes <jbarnes@virtuousgeek.org>,
Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org, stable@kernel.org
Subject: Re: [PATCH] drm/i915: Kill dangerous pending-flip debugging
Date: Wed, 26 May 2010 14:12:01 -0700 [thread overview]
Message-ID: <87k4qql65a.fsf@pollan.anholt.net> (raw)
In-Reply-To: <20100515093117.254dfb1b@blake>
[-- Attachment #1.1: Type: text/plain, Size: 982 bytes --]
On Sat, 15 May 2010 09:31:17 -0700, Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> On Sat, 15 May 2010 09:57:03 +0100
> Chris Wilson <chris@chris-wilson.co.uk> wrote:
>
> > We can, by virtue of a vblank interrupt firing in the middle of
> > setting up the unpin work (i.e. after we set the unpin_work field and
> > before we write to the ringbuffer) enter intel_finish_page_flip()
> > prior to receiving the pending flip notification. Therefore we can
> > expect to hit intel_finish_page_flip() under normal circumstances
> > without a pending flip and even without installing the
> > pending_flip_obj. This is exacerbated by aperture thrashing whilst
> > binding the framebuffer
> >
> > References:
> >
> > Bug 28079 - "glresize" causes kernel panic in
> > intel_finish_page_flip.
> > https://bugs.freedesktop.org/show_bug.cgi?id=28079
>
> Yeah, that's true. Good catch.
>
> Reviewed-by: Jesse Barnes <jbarnes@virtuousgeek.org>
Applied. Thanks!
[-- Attachment #1.2: Type: application/pgp-signature, Size: 197 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2010-05-26 21:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-15 8:57 [PATCH] drm/i915: Kill dangerous pending-flip debugging Chris Wilson
2010-05-15 16:31 ` Jesse Barnes
2010-05-26 21:12 ` Eric Anholt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k4qql65a.fsf@pollan.anholt.net \
--to=eric@anholt.net \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jbarnes@virtuousgeek.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.