New recipe for openmoko QA test scripts

New recipe for openmoko QA test scripts

[Angus Ainslie]

Please review for any policy violations.

Thanks
Angus

--- openembedded/packages/openmoko-projects/openmoko-qa-scripts.bb.oring        1969-12-31 17:00:00.000000000 -0700
+++ openembedded/packages/openmoko-projects/openmoko-qa-scripts.bb      2009-03-02 12:38:55.000000000 -0700
@@ -0,0 +1,19 @@
+DESCRIPTION = "Openmoko QA test scripts"
+SECTION = "utils"
+LICENSE = "GPL"
+PV = "gitr${SRCREV}"
+
+SRC_URI = "git://git.openmoko.org/git/testing_scripts;protocol=git"
+S = "${WORKDIR}/git"
+
+RDEPENDS = "\
+  bluez4 \
+  opkg \
+  xrandr \
+  task-boot \
+"
+
+do_install() {
+          install -d ${D}/usr/bin
+          install ${S}/bin/* ${D}/usr/bin/
+}

Re: New recipe for openmoko QA test scripts

[Denys Dmytriyenko]

On Mon, Mar 02, 2009 at 12:44:03PM -0700, Angus Ainslie wrote:
> Please review for any policy violations.
> 
> Thanks
> Angus
> 
> --- openembedded/packages/openmoko-projects/openmoko-qa-scripts.bb.oring        1969-12-31 17:00:00.000000000 -0700
> +++ openembedded/packages/openmoko-projects/openmoko-qa-scripts.bb      2009-03-02 12:38:55.000000000 -0700
> @@ -0,0 +1,19 @@
> +DESCRIPTION = "Openmoko QA test scripts"
> +SECTION = "utils"
> +LICENSE = "GPL"
> +PV = "gitr${SRCREV}"

I don't believe this is correct. If you don't have a version number besides 
git revision, use:

PV = "0.0+gitr${SRCREV}"

There are many such recipes in OE.

> +SRC_URI = "git://git.openmoko.org/git/testing_scripts;protocol=git"
> +S = "${WORKDIR}/git"
> +
> +RDEPENDS = "\
> +  bluez4 \
> +  opkg \
> +  xrandr \
> +  task-boot \

Looks like a strange set of dependencies, but to be honest, I haven't looked 
into the actual testing_scripts...

> +"
> +
> +do_install() {
> +          install -d ${D}/usr/bin
> +          install ${S}/bin/* ${D}/usr/bin/
> +}

-- 
Denys

Re: New recipe for openmoko QA test scripts

[Koen Kooi]

On 02-03-09 20:44, Angus Ainslie wrote:
> Please review for any policy violations.
>
> Thanks
> Angus
>
> --- openembedded/packages/openmoko-projects/openmoko-qa-scripts.bb.oring        1969-12-31 17:00:00.000000000 -0700
> +++ openembedded/packages/openmoko-projects/openmoko-qa-scripts.bb      2009-03-02 12:38:55.000000000 -0700
> @@ -0,0 +1,19 @@
> +DESCRIPTION = "Openmoko QA test scripts"
> +SECTION = "utils"
> +LICENSE = "GPL"
> +PV = "gitr${SRCREV}"

NACK, as pointed out numerous times before: git revisions don't sort, so 
the above breaks upgrade paths.

Re: New recipe for openmoko QA test scripts

[Otavio Salvador]

Koen Kooi <k.kooi@student.utwente.nl> writes:

> On 02-03-09 20:44, Angus Ainslie wrote:
>> Please review for any policy violations.
>>
>> Thanks
>> Angus
>>
>> --- openembedded/packages/openmoko-projects/openmoko-qa-scripts.bb.oring        1969-12-31 17:00:00.000000000 -0700
>> +++ openembedded/packages/openmoko-projects/openmoko-qa-scripts.bb      2009-03-02 12:38:55.000000000 -0700
>> @@ -0,0 +1,19 @@
>> +DESCRIPTION = "Openmoko QA test scripts"
>> +SECTION = "utils"
>> +LICENSE = "GPL"
>> +PV = "gitr${SRCREV}"
>
> NACK, as pointed out numerous times before: git revisions don't sort,
> so the above breaks upgrade paths.

Our proposal to use git describe solves this :-)

-- 
Otavio Salvador                  O.S. Systems
E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854         http://projetos.ossystems.com.br