All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kalle.valo@nokia.com>
To: linux-wireless@vger.kernel.org
Subject: Thoughts about mac80211 client PS implementation
Date: Wed, 05 Nov 2008 22:27:30 +0200	[thread overview]
Message-ID: <87k5bhkjf1.fsf@nokia.com> (raw)

I'm working on implementing the "dynamic Power Save" (ie. PS enabled
after an idle period) feature to mac80211. Here are my current
thoughts:

First of all, I think we should enable CONF_PS only when associated.
So instead of directly calling hw_config() from
ieee80211_ioctl_siwpower() we should do that only when associated.
Otherwise we change it only after association or disassociation. This
means that we have to add a separate bit/variable for storing what
user has requested.

PS should be disabled while associated and running software scan, and
naturally re-enabled after the scan has finished. I assume hardware
scanning implementations are clever enough to disable PS when scanning
and we don't have to worry about that case.

The dynamic PS implementation is still a bit open issue for me. I have
been thinking something like that in tx.c frames will be queued if PS
is enabled, PS will be disabled in a workqueue by calling
ieee80211_hw_config() and only after that the queued frames are
transfered. So something similar as sta->ps_tx_buf does in AP mode. No
idea if this is feasible or not.

Any comments before I'll start writing code?

-- 
Kalle Valo

             reply	other threads:[~2008-11-05 20:27 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-05 20:27 Kalle Valo [this message]
2008-11-05 20:33 ` Thoughts about mac80211 client PS implementation Johannes Berg
2008-11-05 20:43   ` Luis R. Rodriguez
2008-11-05 21:06     ` Kalle Valo
2008-11-06 12:20     ` Felix Fietkau
2008-11-05 20:54   ` Kalle Valo
2008-11-05 21:05     ` Johannes Berg
2008-11-05 21:25       ` Kalle Valo
2008-11-05 21:55         ` Tomas Winkler
2008-11-06  7:35           ` Kalle Valo
2008-11-06 11:00         ` Johannes Berg
2008-11-07 16:06           ` Johannes Berg
2008-11-07 17:58             ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k5bhkjf1.fsf@nokia.com \
    --to=kalle.valo@nokia.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.