From: Peter Korsgaard <jacmet@sunsite.dk>
To: Guennadi Liakhovetski <lg@denx.de>
Cc: Steve.Glendinning@smsc.com, netdev@vger.kernel.org,
Ian.Saturley@smsc.com
Subject: Re: [PATCH, RFC] Extend smc911x to support LAN921x chips
Date: Sat, 11 Oct 2008 18:48:08 +0200 [thread overview]
Message-ID: <87k5cfoz7b.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <Pine.LNX.4.64.0810111057030.4425@axis700.grange> (Guennadi Liakhovetski's message of "Sat\, 11 Oct 2008 11\:00\:40 +0200 \(CEST\)")
>>>>> "Guennadi" == Guennadi Liakhovetski <lg@denx.de> writes:
Hi,
Guennadi> On Sat, 11 Oct 2008, Peter Korsgaard wrote:
>> >>>>> "Guennadi" == Guennadi Liakhovetski <lg@denx.de> writes:
>>
>> It looks good, but you should definately split out the arm and cleanup
>> stuff from the new IDs.
Guennadi> You mean remove the new IDs? Why?
No, just have them in seperate patches - They are independent of each
other, so no need to put in the same patch.
>> What's this for? Isn't that handled just above?
Guennadi> I think, there's a bug in the code there. The break above
Guennadi> terminates the loop, yes, but then it falls through in the
Guennadi> switch statement to the default case and overwrites the
Guennadi> just found PHY.
Ahh, the good old break-only-escapes-the-innermost-scope. That's a
good fix, but please send it seperately from the patch adding the new
IDs.
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2008-10-11 16:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-09 15:26 Extend smc911x to support LAN921x chips - differences? Steve.Glendinning
2008-09-09 16:18 ` Guennadi Liakhovetski
2008-09-09 20:08 ` Peter Korsgaard
2008-10-10 23:33 ` [PATCH, RFC] Extend smc911x to support LAN921x chips Guennadi Liakhovetski
2008-10-11 7:22 ` Peter Korsgaard
2008-10-11 9:00 ` Guennadi Liakhovetski
2008-10-11 16:48 ` Peter Korsgaard [this message]
2008-10-11 20:30 ` Guennadi Liakhovetski
2008-10-12 7:38 ` Peter Korsgaard
2008-10-11 21:10 ` [PATCH] smc911x: Fix external PHY detection Guennadi Liakhovetski
2008-10-11 22:07 ` David Miller
2008-10-12 7:43 ` Peter Korsgaard
2008-10-11 21:13 ` [PATCH] smc911x: Add support for LAN921{5,7,8} chips from SMSC Guennadi Liakhovetski
2008-10-11 22:08 ` David Miller
2008-10-11 22:59 ` [PATCH v2] " Guennadi Liakhovetski
2008-10-12 7:54 ` Peter Korsgaard
2008-10-13 4:05 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k5cfoz7b.fsf@macbook.be.48ers.dk \
--to=jacmet@sunsite.dk \
--cc=Ian.Saturley@smsc.com \
--cc=Steve.Glendinning@smsc.com \
--cc=lg@denx.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.