From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KQJXo-0006lZ-CF for mharc-grub-devel@gnu.org; Tue, 05 Aug 2008 06:13:32 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KQJXl-0006jQ-Cz for grub-devel@gnu.org; Tue, 05 Aug 2008 06:13:29 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KQJXj-0006iW-KO for grub-devel@gnu.org; Tue, 05 Aug 2008 06:13:28 -0400 Received: from [199.232.76.173] (port=54311 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KQJXj-0006iL-E8 for grub-devel@gnu.org; Tue, 05 Aug 2008 06:13:27 -0400 Received: from smtp-vbr1.xs4all.nl ([194.109.24.21]:1911) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KQJXj-0004f2-71 for grub-devel@gnu.org; Tue, 05 Aug 2008 06:13:27 -0400 Received: from localhost.localdomain (249-174.surfsnel.dsl.internl.net [145.99.174.249]) by smtp-vbr1.xs4all.nl (8.13.8/8.13.8) with ESMTP id m75ADPNf049098 for ; Tue, 5 Aug 2008 12:13:26 +0200 (CEST) (envelope-from mgerards@xs4all.nl) From: Marco Gerards To: The development of GRUB 2 References: <1217459965.26275.14.camel@fz-deb.local> <877ib1hvce.fsf@xs4all.nl> <20080801130222.GA12405@thorin> Mail-Copies-To: mgerards@xs4all.nl Date: Tue, 05 Aug 2008 12:16:04 +0200 In-Reply-To: <20080801130222.GA12405@thorin> (Robert Millan's message of "Fri, 1 Aug 2008 15:02:22 +0200") Message-ID: <87k5evhimz.fsf@xs4all.nl> User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Virus-Scanned: by XS4ALL Virus Scanner X-detected-kernel: by monty-python.gnu.org: FreeBSD 4.6-4.9 Subject: Re: [PATCH] skip over invalid BSD partitions X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Aug 2008 10:13:29 -0000 Robert Millan writes: > On Fri, Aug 01, 2008 at 12:40:17PM +0200, Marco Gerards wrote: >> > - return grub_error (GRUB_ERR_BAD_PART_TABLE, >> > - "no space for disk label"); >> > - >> > + { >> > + grub_error (GRUB_ERR_BAD_PART_TABLE, >> > + "no space for disk label"); >> > + continue; >> > + } >> >> If you continue as no error occured, why do you throw an error? > > Uhm nobody's going to handle this error. The caller will simply see that > some partitions are not processed. > > How about using grub_dprintf instead? Agreed. -- Marco