All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Markus Klotzbücher" <mk@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH 2/3] Added USB PCI-OHCI chips support, interrupt pipe support and usb event poll support.
Date: Tue, 15 May 2007 10:01:38 +0000	[thread overview]
Message-ID: <87k5va1k3h.fsf@denx.de> (raw)
In-Reply-To: <46B96294322F7D458F9648B60E15112C234227@zch01exm26.fsl.freescale.net> (Zhang Wei-r's message of "Tue, 15 May 2007 17:02:56 +0800")

Hi Zhang Wei,

"Zhang Wei-r63237" <Wei.Zhang@freescale.com> writes:

>> So this BE CPU and LE Controller again. The only problem I 
>> see with your
>> fix is that because you _always_ do byteswapping for register accesses
>> on BE CPUs, this would break support for the case BE CPU and BE OHCI
>> Controller (but which doesn't exist in U-Boot so far).
>> 
>> No need to change this now, because I'm going to clean this 
>> up soon, but
>> I'd appreciate your help in testing once this is done.
>> 
>
> I'm using m32_swap(), it is not _always_ do. You can see following
> codes in usb_ohci.c:

I see, you're right. Still, this mess needs to be cleaned up. I'll start
a new thread.

Best regards

Markus

--
DENX Software Engineering GmbH, HRB 165235 Munich, CEO: Wolfgang Denk
Office:  Kirchenstr. 5,       D-82194 Groebenzell,            Germany

  reply	other threads:[~2007-05-15 10:01 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-25  3:48 [U-Boot-Users] [PATCH 2/3] Added USB PCI-OHCI chips support, interrupt pipe support and usb event poll support Zhang Wei
2007-05-14 14:47 ` Markus Klotzbücher
2007-05-15  2:35   ` Zhang Wei-r63237
2007-05-15  8:27     ` Markus Klotzbücher
2007-05-15  9:02       ` Zhang Wei-r63237
2007-05-15 10:01         ` Markus Klotzbücher [this message]
2007-05-16  2:05           ` Zhang Wei-r63237
2007-05-21  2:39             ` Zhang Wei-r63237
2007-05-22  9:06               ` Markus Klotzbücher
2007-06-06 10:52               ` Markus Klotzbücher
2007-06-06 19:31                 ` Jon Loeliger
2007-06-07  9:12                 ` Zhang Wei-r63237
2007-06-11 13:28                   ` Markus Klotzbücher
2007-07-03  8:25 ` Robert Delien
2007-07-03  9:01   ` Zhang Wei-r63237
2007-07-03 10:13     ` Robert Delien
2007-07-03 10:39       ` Zhang Wei-r63237

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k5va1k3h.fsf@denx.de \
    --to=mk@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.