All of lore.kernel.org
 help / color / mirror / Atom feed
From: Elias Oltmanns <eo@nebensachen.de>
To: linux-ide@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: [PATCH] IDE: typo in ide-io.c leads to faulty assignment
Date: Mon, 27 Nov 2006 15:51:33 +0100	[thread overview]
Message-ID: <87k61h3pu2.fsf@denkblock.local> (raw)

[-- Attachment #1: Type: text/plain, Size: 258 bytes --]

Due to a typo in ide_start_power_step, the result of a function rather
than its pointer is assigned to args->handler. The patch applies to
2.6.19-rc6 but the problem exists in the stable branch as well.

Signed-off-by: Elias Oltmanns <eo@nebensachen.de>
---

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: ide-io.c.patch --]
[-- Type: text/x-patch, Size: 542 bytes --]

diff --git a/drivers/ide/ide-io.c b/drivers/ide/ide-io.c
index 2614f41..48a249d 100644
--- a/drivers/ide/ide-io.c
+++ b/drivers/ide/ide-io.c
@@ -213,7 +213,7 @@ static ide_startstop_t ide_start_power_s
 	case idedisk_pm_idle:		/* Resume step 2 (idle) */
 		args->tfRegister[IDE_COMMAND_OFFSET] = WIN_IDLEIMMEDIATE;
 		args->command_type = IDE_DRIVE_TASK_NO_DATA;
-		args->handler = task_no_data_intr;
+		args->handler = &task_no_data_intr;
 		return do_rw_taskfile(drive, args);
 
 	case ide_pm_restore_dma:	/* Resume step 3 (restore DMA) */

             reply	other threads:[~2006-11-27 14:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-27 14:51 Elias Oltmanns [this message]
2006-11-27 15:08 ` [PATCH] IDE: typo in ide-io.c leads to faulty assignment Alan
2006-11-27 16:01 ` Jesper Juhl
2006-11-27 16:31   ` Elias Oltmanns

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k61h3pu2.fsf@denkblock.local \
    --to=eo@nebensachen.de \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.