All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marco Gerards <metgerards@student.han.nl>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [ppc patch] setjmp/longjmp
Date: Tue, 16 Nov 2004 10:01:44 +0000	[thread overview]
Message-ID: <87k6sm9kon.fsf@marco.marco-g.com> (raw)
In-Reply-To: <20041116045636.GA3896@miracle> (Hollis Blanchard's message of "Mon, 15 Nov 2004 22:56:36 -0600")

Hollis Blanchard <hollis@penguinppc.org> writes:

> I've implemented setjmp and longjmp for PowerPC. Annoyingly, because PPC
> still has no module support, files are compiled with -DGRUB_UTIL=1, and
> that causes include/grub/setjmp.h to redefine both functions. I guess
> that means we used to link in the libc setjmp/longjmp (which then failed
> miserably when one tried to run them).

Nice.  This evening I will try to fix that -DGRUB_UTIL thing and test
this code of yours.

>   * normal/powerpc/setjmp.S (grub_setjmp): New function.
>   (grub_longjmp): Likewise.

You can better say:

* normal/powerpc/setjmp.S: New file.

When you make a new file and you did not move old code there saying it
is a new file is sufficient.

> Index: conf/powerpc-ieee1275.rmk
...
> +	normal/powerpc/setjmp.S \

I don't see this change in your changelog entry.

Thanks,
Marco




  reply	other threads:[~2004-11-16 10:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-11-16  4:56 [ppc patch] setjmp/longjmp Hollis Blanchard
2004-11-16 10:01 ` Marco Gerards [this message]
2004-11-16 16:04   ` Hollis Blanchard
2004-11-16 16:47     ` Marco Gerards
2004-11-16 23:34 ` Marco Gerards
2004-11-17 10:11   ` Yoshinori K. Okuji
2004-11-17 15:20     ` Marco Gerards

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k6sm9kon.fsf@marco.marco-g.com \
    --to=metgerards@student.han.nl \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.