From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.33) id 1BeXIa-0000c6-FU for mharc-grub-devel@gnu.org; Sun, 27 Jun 2004 06:54:12 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1BeXIY-0000ad-SG for grub-devel@gnu.org; Sun, 27 Jun 2004 06:54:10 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1BeXIW-0000ZS-SG for grub-devel@gnu.org; Sun, 27 Jun 2004 06:54:10 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1BeXIW-0000ZP-P0 for grub-devel@gnu.org; Sun, 27 Jun 2004 06:54:08 -0400 Received: from [145.74.66.11] (helo=mail-cn.han.nl) by monty-python.gnu.org with esmtp (Exim 4.34) id 1BeXGt-0007wo-N6 for grub-devel@gnu.org; Sun, 27 Jun 2004 06:52:28 -0400 Received: from localhost (charlie.han.nl [145.74.66.9]) by mail-cn.han.nl (Postfix) with ESMTP id 759CC889D; Sun, 27 Jun 2004 12:45:38 +0200 (CEST) Received: from mail-cn.han.nl ([145.74.66.11]) by localhost (charlie.han.nl [145.74.66.9]) (amavisd-new, port 10024) with ESMTP id 29620-01; Sun, 27 Jun 2004 12:45:36 +0200 (CEST) Received: from mail1.han.nl (mail1.han.nl [145.74.103.11]) by mail-cn.han.nl (Postfix) with ESMTP id 04A8F88AA; Sun, 27 Jun 2004 12:45:36 +0200 (CEST) Received: from marco.marco-g.com (a82-92-27-129.adsl.xs4all.nl [82.92.27.129]) by mail1.han.nl (Postfix) with ESMTP id 2C4EDC046; Sun, 27 Jun 2004 11:45:35 +0200 (CEST) Mail-Copies-To: metgerards@student.han.nl To: ebik@ucw.cz References: <20040601121704.GA4680@artax.karlin.mff.cuni.cz> <20040601201320.GA10705@artax.karlin.mff.cuni.cz> From: Marco Gerards Date: Sun, 27 Jun 2004 12:45:41 +0200 In-Reply-To: <20040601201320.GA10705@artax.karlin.mff.cuni.cz> (Tomas Ebenlendr's message of "Tue, 1 Jun 2004 22:13:20 +0200") Message-ID: <87k6xt46ui.fsf@marco.marco-g.com> User-Agent: Gnus/5.1006 (Gnus v5.10.6) Emacs/21.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Virus-Scanned: by amavisd-new@vscan-cn.han.nl Cc: The development of GRUB 2 Subject: Re: ext2 find patch X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.4 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 27 Jun 2004 10:54:11 -0000 ebik@artax.karlin.mff.cuni.cz (Tomas Ebenlendr) writes: > The same problem was with symlinks, so the new version of patch is here. > > It does stat every inode (and ignore the info in direntries). > There is also small fix in absolute symlinks (chopping the initial '/') I've checked in your patch, after making some minor changes: 2004-06-27 Tomas Ebenlendr * fs/ext2.c (FILETYPE_INO_MASK, FILETYPE_INO_DIRECTORY) (FILETYPE_INO_SYMLINK): New macros. (grub_ext2_find_file): Check if the node is a directory using the inode stat information instead of using the filetype in the dirent. Exclude the first character of an absolute symlink. (grub_ext2_dir): Mask out the filetype part of the mode member of the inode. I do not know why you moved the code to read the inode around. I didn't check that in. Why is that required? Please test if this works for you now. It fixed my problem. Thanks, Marco