From: "Flávio Amieiro" <flavio@amieiro.net>
To: sashiko-reviews@lists.linux.dev
Cc: linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
robh@kernel.org, conor+dt@kernel.org, lee@kernel.org
Subject: Re: [PATCH v5 2/2] leds: is31f132xx: Add support for is31fl3206
Date: Sat, 14 Nov 2026 21:41:23 -0300 [thread overview]
Message-ID: <87ld6vncy4.fsf@berlin> (raw)
In-Reply-To: <sashiko-outbox-215144@kernel.org>
sashiko-bot@kernel.org writes:
> Thank you for your contribution! Sashiko AI review found 1 potential
> issue to consider:
> - [Low] leds: is31fl32xx: mixed declarations and code in
> is31fl32xx_init_regs()
> --
> [Severity: Low]
> As reported by Lee Jones on v4 [1], placing the shift of value before the
> declarations of num_regs and i mixes declarations and statements in
> is31fl32xx_init_regs(). Could the shift be moved below the variable
> declarations or folded into the initializer?
...
> [1] https://lore.kernel.org/r/179370064610.793788.8239015594326628135@kernel.org
I missed that change in the new version. I'm sorry about that. I will
fix this, but I'll wait a while for more feedback before I send a new
version in case there is anything else to change.
prev parent reply other threads:[~2026-11-15 0:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-15 0:12 [PATCH v5 0/2] leds: Add support for the is31fl3206 LED driver Flavio Amieiro
2026-11-15 0:12 ` [PATCH v5 1/2] dt-bindings: leds: Add issi,is31fl3206 to leds-is31fl32xx Flavio Amieiro
2026-11-15 0:15 ` sashiko-bot
2026-11-15 0:12 ` [PATCH v5 2/2] leds: is31f132xx: Add support for is31fl3206 Flavio Amieiro
2026-11-15 0:23 ` sashiko-bot
2026-11-15 0:41 ` Flávio Amieiro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ld6vncy4.fsf@berlin \
--to=flavio@amieiro.net \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lee@kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.