All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Toke Høiland-Jørgensen" <toke@toke.dk>
To: Mehmet Fide <mehmet.fide@gmail.com>,
	Jeff Johnson <jeff.johnson@oss.qualcomm.com>,
	Pengpeng Hou <pengpeng@iscas.ac.cn>
Cc: Sasha Levin <sashal@kernel.org>,
	linux-wireless@vger.kernel.org, stable@vger.kernel.org,
	regressions@lists.linux.dev, mehmet.fide@screeningeagle.com,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH v2] wifi: ath9k: reject short WMI command responses
Date: Fri, 16 Oct 2026 10:32:13 +0200	[thread overview]
Message-ID: <87ld7yxcz6.fsf@toke.dk> (raw)
In-Reply-To: <20261015184044.1321868-1-mehmet.fide@gmail.com>

Mehmet Fide <mehmet.fide@gmail.com> writes:

> Hi,
>
> this change breaks ath9k_htc with the AR9271 firmware from linux-firmware
> (ath9k_htc/htc_9271-1.4.0.fw, "FW Version: 1.4"). The firmware answers
> most commands with an empty payload, while the driver passes a response
> buffer for every command: cmd_rsp in WMI_CMD()/WMI_CMD_BUF(), the 4-byte
> value of WMI_REG_WRITE_CMDID, the 4- or 12-byte buffer of
> WMI_REG_RMW_CMDID. With the new check all of these calls return
> -EMSGSIZE, and bringing the interface up fails (hostapd: "Could not set
> interface wlan0 flags (UP): Message too long").

Thank you for the detailed report! And apologies for the regression;
seems I need to do better at pushing back on untested slop patches :(

Given the lateness of the RC, I'll send a revert directly to Linus,
hopefully he can merge that ahead of the 7.3 release.

-Toke

      reply	other threads:[~2026-10-16  8:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-14  7:58 [PATCH v2] wifi: ath9k: reject short WMI command responses Pengpeng Hou
2026-09-16 18:40 ` Jeff Johnson
2026-09-17  8:56   ` Toke Høiland-Jørgensen
2026-09-18 19:55     ` Jeff Johnson
2026-09-21 18:00 ` Jeff Johnson
2026-10-15 18:40 ` Mehmet Fide
2026-10-16  8:32   ` Toke Høiland-Jørgensen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ld7yxcz6.fsf@toke.dk \
    --to=toke@toke.dk \
    --cc=jeff.johnson@oss.qualcomm.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=mehmet.fide@gmail.com \
    --cc=mehmet.fide@screeningeagle.com \
    --cc=pengpeng@iscas.ac.cn \
    --cc=regressions@lists.linux.dev \
    --cc=sashal@kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.