Re: [PATCH] ALSA: hda/realtek: Drop unneeded DAC override for HONOR MagicBook Pro 16 2024

[Takashi Iwai <tiwai@suse.de>]

On Mon, 05 Oct 2026 22:38:36 +0200,
Denis Yakovlev wrote:
> 
> Commit 1e3e378d63be ("ALSA: hda/realtek: Enable bass speakers on HONOR
> MagicBook Pro 16 2024") restricted the speaker pin 0x1b to DAC 0x02, on
> the assumption that the second speaker pair would otherwise end up on
> DAC 0x03, as channels 3/4 that a stereo stream never reaches. That
> assumption was wrong: without the override, pin 0x1b is still connected
> to DAC 0x02, the only DAC that pin 0x14 can use, so the override changes
> nothing. With and without it the codec routing is identical and the
> speakers behave the same with nothing plugged in, with headphones and
> with a CTIA headset inserted; without it they also keep working after
> suspend/resume.
> 
> That commit also got the speaker roles the wrong way round. Pin 0x1b,
> which the BIOS does configure, drives the bottom speakers, which carry
> the low and mid frequencies; pin 0x14 drives the tweeters next to the
> keyboard, and those are the speakers that stay silent without the quirk.
> Measured with the internal microphones, enabling one pin at a time: at
> 1 kHz the 0x14 pair alone is more than 30 dB below the 0x1b pair alone,
> while at 6 kHz the two are within 10 dB of each other.
> 
> Drop the DAC override and correct the pin comment, so the quirk only
> sets pin configurations, like the one for the sibling M1020 board
> (HONOR MRB-XXX).
> 
> Fixes: 1e3e378d63be ("ALSA: hda/realtek: Enable bass speakers on HONOR MagicBook Pro 16 2024")
> Assisted-by: LLM
> Signed-off-by: Denis Yakovlev <mfthesun@vivaldi.net>

Applied to for-next branch.  Thanks.


Takashi