From: Takashi Iwai <tiwai@suse.de>
To: Runyu Xiao <runyu.xiao@seu.edu.cn>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org, Jianhao Xu <jianhao.xu@seu.edu.cn>
Subject: Re: [PATCH] ALSA: sgio2audio: Only free successfully requested IRQs
Date: Tue, 29 Sep 2026 17:09:09 +0200 [thread overview]
Message-ID: <87ld8kyu0a.wl-tiwai@suse.de> (raw)
In-Reply-To: <20260929084540.2065213-1-runyu.xiao@seu.edu.cn>
On Tue, 29 Sep 2026 10:45:40 +0200,
Runyu Xiao wrote:
>
> snd_sgio2audio_create() calls snd_sgio2audio_free() when an IRQ
> request fails. The cleanup helper currently walks the complete IRQ table,
> including entries whose request_irq() calls have not been attempted yet.
> free_irq() then receives an IRQ and dev_id pair that was never registered.
>
> Pass the number of successfully requested IRQs to the cleanup helper on
> the request failure path, while retaining the full-table cleanup for
> teardown after all requests have succeeded.
>
> Fixes: 862c2c0a61c5 ("ALSA: ALSA driver for SGI O2 audio board")
> Cc: stable@vger.kernel.org
> Assisted-by: LLM
> Signed-off-by: Runyu Xiao <runyu.xiao@seu.edu.cn>
Applied to for-next branch. Thanks.
Takashi
prev parent reply other threads:[~2026-09-29 15:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-29 8:45 [PATCH] ALSA: sgio2audio: Only free successfully requested IRQs Runyu Xiao
2026-09-29 15:09 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ld8kyu0a.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=jianhao.xu@seu.edu.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=runyu.xiao@seu.edu.cn \
--cc=stable@vger.kernel.org \
--cc=tiwai@suse.com \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.