From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C2BB8C982CF for ; Thu, 17 Sep 2026 11:59:10 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1x7AlT-0002uR-Qb; Thu, 17 Sep 2026 07:58:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x7AlP-0002uH-9O for qemu-devel@nongnu.org; Thu, 17 Sep 2026 07:58:51 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x7AlM-0002nG-SU for qemu-devel@nongnu.org; Thu, 17 Sep 2026 07:58:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1789646325; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=nMHfb3ytzZu1CF/Mzffb9hqOCDgm/VsD6aj0n1fJbKQ=; b=TD9trVlJBkTj3ZCU7vz8qVDzP0dPFiwh1wg42+biIQy/30MO5XYfLde7CdiLsmVycHYz7x dJ2i6/xI/luh5TkcakPVYagrBTTUWWm4qu5jDKqPOzAnyIF9xsGBAZFz+rdyqYtXv9KdLg BAxwBJobn7AiqMLx0Smj0aAdoWVr9eY= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-518-WdIPN12gPDioyBIPg5Ugkg-1; Thu, 17 Sep 2026 07:58:43 -0400 X-MC-Unique: WdIPN12gPDioyBIPg5Ugkg-1 X-Mimecast-MFC-AGG-ID: WdIPN12gPDioyBIPg5Ugkg_1789646322 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 8CFC9195FD3E; Thu, 17 Sep 2026 11:58:42 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.44.22.5]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id DE53A1800345; Thu, 17 Sep 2026 11:58:41 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 4089721E6A04; Thu, 17 Sep 2026 13:58:39 +0200 (CEST) From: Markus Armbruster To: Markus Armbruster Cc: Fabiano Rosas , qemu-devel@nongnu.org, Peter Xu , "Dr . David Alan Gilbert" Subject: Re: [PATCH v3 14/20] migration: Use output visitor in info command In-Reply-To: <87zexg2ix9.fsf@pond.sub.org> (Markus Armbruster's message of "Thu, 17 Sep 2026 13:53:22 +0200") References: <20260915000209.3692668-1-farosas@suse.de> <20260915000209.3692668-15-farosas@suse.de> <87zexg2ix9.fsf@pond.sub.org> Date: Thu, 17 Sep 2026 13:58:39 +0200 Message-ID: <87ld90t7gw.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass client-ip=170.10.133.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Markus Armbruster writes: > Fabiano Rosas writes: > >> The hmp_info_migrate_parameters function currently open-codes the >> mon_printf calls for each migration parameter. As with the set command >> in the last patch, this should not be necessary as the QAPI >> infrastructure already has generated code that takes type and struct >> member names into account, including converting _ from C into the '-' >> character as part of parameter names strings. >> >> The current code is also quite painful to rebase if a series has been >> carried for a long time while parameters have been added in master. >> >> Replace all of this with a conversion from MigrationParameters to >> QDict using an output visitor and a loop over the QDict that prints >> per-QAPI-type formatted strings. >> >> Modelled after block/qapi.c:dump_qobject, but with some changes to >> keep the migration command output formatting. >> >> Signed-off-by: Fabiano Rosas > > Old output of info migrate_parameters for me: > > announce-initial: 50 > announce-max: 550 > announce-rounds: 5 > announce-step: 100 > throttle-trigger-threshold: 50 > cpu-throttle-initial: 20 > cpu-throttle-increment: 10 > cpu-throttle-tailslow: off > max-cpu-throttle: 99 > tls-creds: > tls-hostname: > tls-authz: > max-bandwidth: 134217728 > avail-switchover-bandwidth: 0 > max-postcopy-bandwidth: 0 > downtime-limit: 300 > x-checkpoint-delay: 20000 > multifd-channels: 2 > multifd-compression: none > zero-page-detection: multifd > xbzrle-cache-size: 67108864 > x-vcpu-dirty-limit-period: 1000 > vcpu-dirty-limit: 1 > mode: normal > direct-io: off > x-rdma-chunk-size: 1048576 > cpr-exec-command: > > New output: > > cpu-throttle-tailslow: off > xbzrle-cache-size: 67108864 > cpu-throttle-initial: 20 > announce-max: 550 > direct-io: off > avail-switchover-bandwidth: 0 > local: off > zero-page-detection: multifd > multifd-qatzip-level: 1 > x-rdma-chunk-size: 1048576 > multifd-channels: 2 > mode: normal > multifd-zstd-level: 1 > announce-initial: 50 > downtime-limit: 300 > tls-authz: > cpr-exec-command: > > vcpu-dirty-limit: 1 > multifd-compression: none > announce-rounds: 5 > announce-step: 100 > tls-creds: > x-vcpu-dirty-limit-period: 1000 > multifd-zlib-level: 1 > max-cpu-throttle: 99 > max-postcopy-bandwidth: 0 > tls-hostname: > throttle-trigger-threshold: 50 > max-bandwidth: 134217728 > x-checkpoint-delay: 20000 > cpu-throttle-increment: 10 > > New output has an unwanted blank line after "cpr-exec-command:". > > New output adds @local, @multifd-qatzip-level, @multifd-zlib-level, > @multifd-zstd-level. Commit message should point that out. > > Order of parameters changes, and not for the better. Hmm. Neither shows @block-bitmap-mapping. [...]