From: Jakub Sitnicki <jakub@cloudflare.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, Florian Westphal <fw@strlen.de>,
Paolo Abeni <pabeni@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Simon Horman <horms@kernel.org>,
Jeremy Kerr <jk@codeconstruct.com.au>,
Matt Johnston <matt@codeconstruct.com.au>,
Steffen Klassert <steffen.klassert@secunet.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
kernel-team@cloudflare.com
Subject: Re: [PATCH net-next 1/2] net: Make skb_ext_put_sp() idempotent
Date: Wed, 02 Sep 2026 07:51:57 +0200 [thread overview]
Message-ID: <87ld9k2oaq.fsf@cloudflare.com> (raw)
In-Reply-To: <20260901171520.072acdd2@kernel.org> (Jakub Kicinski's message of "Tue, 1 Sep 2026 17:15:20 -0700")
On Tue, Sep 01, 2026 at 05:15 PM -07, Jakub Kicinski wrote:
> On Mon, 31 Aug 2026 08:27:38 +0200 Jakub Sitnicki wrote:
>> + if (!sp->len)
>> + return;
>
> Somewhat mixed feelings about explicitly checking what is the loop
> bound, anyway. But I guess you can argue we shouldn't write len?
> Probably not worth a respin either way
You read my mind. Then I thought maybe I'm trying to be smarter than the
compiler? But it seems that neither clang nor gcc eliminate the write:
https://godbolt.org/z/EcWTdEYqh
>
>> for (i = 0; i < sp->len; i++)
>> xfrm_state_put(sp->xvec[i]);
>> + sp->len = 0;
next prev parent reply other threads:[~2026-09-02 5:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-31 6:27 [PATCH net-next 0/2] net: Prepare skb extensions for reuse across scrubs Jakub Sitnicki
2026-08-31 6:27 ` [PATCH net-next 1/2] net: Make skb_ext_put_sp() idempotent Jakub Sitnicki
2026-09-02 0:15 ` Jakub Kicinski
2026-09-02 5:51 ` Jakub Sitnicki [this message]
2026-09-02 9:24 ` Paolo Abeni
2026-09-02 14:03 ` Florian Westphal
2026-08-31 6:27 ` [PATCH net-next 2/2] net: Make skb_ext_put_mctp() idempotent Jakub Sitnicki
2026-09-01 5:26 ` Jeremy Kerr
2026-09-02 0:36 ` [PATCH net-next 0/2] net: Prepare skb extensions for reuse across scrubs patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ld9k2oaq.fsf@cloudflare.com \
--to=jakub@cloudflare.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=herbert@gondor.apana.org.au \
--cc=horms@kernel.org \
--cc=jk@codeconstruct.com.au \
--cc=kernel-team@cloudflare.com \
--cc=kuba@kernel.org \
--cc=matt@codeconstruct.com.au \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.