All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: John Snow <jsnow@redhat.com>
Cc: qemu-devel@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Kohei Tokunaga" <ktokunaga.mail@gmail.com>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Michael Roth" <michael.roth@amd.com>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Mauro Carvalho Chehab" <mchehab+huawei@kernel.org>,
	"Cleber Rosa" <crosa@redhat.com>,
	"Pierrick Bouvier" <pierrick.bouvier@oss.qualcomm.com>,
	"Philippe Mathieu-Daudé" <philmd@mailo.com>
Subject: Re: [PATCH 04/12] qapi: update type hint for types_seen
Date: Mon, 24 Aug 2026 10:05:46 +0200	[thread overview]
Message-ID: <87ld9wt02t.fsf@pond.sub.org> (raw)
In-Reply-To: <20260824052859.880475-5-jsnow@redhat.com> (John Snow's message of "Mon, 24 Aug 2026 01:28:50 -0400")

John Snow <jsnow@redhat.com> writes:

> In preparation for upgrading Python to 3.12+, adjust the type hint on
> types_seen to prevent mypy from chirping about an unknown type for
> this variable.
>
> Why didn't this trigger earlier? A mystery for the ages.
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
>  scripts/qapi/types.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/qapi/types.py b/scripts/qapi/types.py
> index 2bf75338283..b87377c6474 100644
> --- a/scripts/qapi/types.py
> +++ b/scripts/qapi/types.py
> @@ -34,7 +34,7 @@
>  
>  # variants must be emitted before their container; track what has already
>  # been output
> -objects_seen = set()
> +objects_seen: set[str] = set()
>  
>  
>  def gen_enum_lookup(name: str,

Reviewed-by: Markus Armbruster <armbru@redhat.com>



  parent reply	other threads:[~2026-08-24  8:06 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-24  5:28 [PATCH 00/12] python: require python3.12+ John Snow
2026-08-24  5:28 ` [PATCH 01/12] tests: re-add opencv2 and numpy dependencies John Snow
2026-08-24  7:16   ` Philippe Mathieu-Daudé
2026-08-24  7:38   ` marcandre.lureau
2026-08-24  5:28 ` [PATCH 02/12] tests: add Python3.12 to centos9.docker John Snow
2026-08-24  7:38   ` marcandre.lureau
2026-08-24  8:17     ` Paolo Bonzini
2026-08-24 13:09       ` John Snow
2026-08-24 13:14         ` Daniel P. Berrangé
2026-08-24  5:28 ` [PATCH 03/12] tests: update emsdk-wasm64-cross John Snow
2026-08-24  7:38   ` marcandre.lureau
2026-08-25  4:16     ` Kohei Tokunaga
2026-08-24  5:28 ` [PATCH 04/12] qapi: update type hint for types_seen John Snow
2026-08-24  7:17   ` Philippe Mathieu-Daudé
2026-08-24  7:38   ` marcandre.lureau
2026-08-24  8:05   ` Markus Armbruster [this message]
2026-08-24  5:28 ` [PATCH 05/12] python: upgrade to Python3.12+ John Snow
2026-08-24  7:38   ` marcandre.lureau
2026-08-24  8:21   ` Paolo Bonzini
2026-08-24  5:28 ` [PATCH 06/12] python: fix license configuration John Snow
2026-08-24  7:38   ` marcandre.lureau
2026-08-24  5:28 ` [PATCH 07/12] python: allow mypy to run as the current python version John Snow
2026-08-24  7:15   ` Philippe Mathieu-Daudé
2026-08-24  7:38   ` marcandre.lureau
2026-08-24  5:28 ` [PATCH 08/12] python: remove distutils workarounds John Snow
2026-08-24  7:38   ` marcandre.lureau
2026-08-24  5:28 ` [PATCH 09/12] python: remove stale setup.cfg options John Snow
2026-08-24  7:38   ` marcandre.lureau
2026-08-24  5:28 ` [PATCH 10/12] sphinx: require sphinx 7.2.6 John Snow
2026-08-24  7:38   ` marcandre.lureau
2026-08-24 13:16   ` Daniel P. Berrangé
2026-08-24 13:21     ` John Snow
2026-08-24  5:28 ` [PATCH 11/12] sphinx: drop fakedbusdoc John Snow
2026-08-24  7:38   ` marcandre.lureau
2026-08-24  5:28 ` [PATCH 12/12] sphinx: drop qapidoc back-compat overboiled spaghetti dinner John Snow
2026-08-24  7:38   ` marcandre.lureau
2026-08-24  9:39   ` Markus Armbruster
2026-08-24 14:34     ` John Snow

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ld9wt02t.fsf@pond.sub.org \
    --to=armbru@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=crosa@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=ktokunaga.mail@gmail.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=mchehab+huawei@kernel.org \
    --cc=michael.roth@amd.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@mailo.com \
    --cc=pierrick.bouvier@oss.qualcomm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.