Re: [PATCH v3] ALSA: hda/realtek: Enable internal speakers on Razer Blade 16 (2025)

[Takashi Iwai <tiwai@suse.de>]

On Tue, 23 Jun 2026 21:02:07 +0200,
Christopher Höner wrote:
> 
> Hi Takashi,
> 
> thanks for the review.
> 
> v4 moves the captured programming and the fixup into
> sound/hda/codecs/helpers/razer_blade16_2025.c and uses the full model
> name throughout, so it can't be mixed up with other models.
> 
> On power_save_node: it works, but it clicks on every stream start for no
> real benefit here. Given the click -- and the existing fixups that
> disable it for exactly that reason -- I kept the pcm_playback_hook.
> 
> I also couldn't drive the amp from a power_filter: the per-path power-up
> on stream start goes through path_power_update(), which writes the power
> states directly and never consults codec->power_filter (that only runs
> on the codec-wide transitions), so the filter never sees the
> converter/pin coming up for playback.
> 
> I think v4 is ready - I hope you agree.

OK, then let's take it.  But it's a big change and now is already at a
very late stage for 7.2 merge window, I'll postpone the merge for 7.3.


thanks,

Takashi