From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 692F43264D8 for ; Wed, 20 May 2026 22:49:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779317370; cv=none; b=Y6BI5JGZqqCdLlkn4Ai75l1rFUPbFyyoWcZ1R0AHwuBp7YOejoL7yf5cL1wnONHdQv0A3nyJrgR/gpKHIX2jgIXxIbDuzECJIGknxE6Ml9oMz5c1Mkry+D/QqSvqCQEsirhw8AfUCz2hQGYGUL0RIOOD9OJyXzSIGsZ/DWdRlg4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779317370; c=relaxed/simple; bh=bp2jJHMUdRdqXZZnDtTTUCBs2lTa7aQGSSC/KcRu4Zw=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=ie0If9Hq4W61jh+v8OEzeSN/Zheggp/+ducErQP+Kjbur+EymPWgF7KHB3g+mFSeuJ3PtAwacrevFgW9NV77Z4IR0trLJ5WUvTkuP4llnoGy5WYPqK6oDJarK7cvRdbTzvU6PgNkXEMiRZirb/8jKppCQQ79BZgUSjR6GGWwDCo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=h8rSgfum; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=+mkSH+Sy; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=h8rSgfum; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=+mkSH+Sy; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="h8rSgfum"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="+mkSH+Sy"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="h8rSgfum"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="+mkSH+Sy" Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id C9BA96AEBA; Wed, 20 May 2026 22:49:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1779317361; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Wp2ptU7ySVbj8SGonSbemhOk4OytlR4wLpFXI6jr3m0=; b=h8rSgfum9BI0+yVoAQxAOA0swombvG767qmFWRMaTOmnWEUWNjDWEQv+Ye4VTw3BEP3WtR TPgbggPEDvQ3tnNM+KfmhlxniKJppzG29I+CboBtFzgst4509kQQ3lxBz8RLv5Nl9HcK2p lRDKxQgEQ0kAHHwyv6jDkwtDhDaeXsY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1779317361; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Wp2ptU7ySVbj8SGonSbemhOk4OytlR4wLpFXI6jr3m0=; b=+mkSH+SyV5BCA6dg2Hy2SToAiZAEY0HsrPoE0XMJ7pq2Bl6iPglnTRzmISVQTzEbC4RJZa fR4XNt8QzNgf2YBQ== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1779317361; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Wp2ptU7ySVbj8SGonSbemhOk4OytlR4wLpFXI6jr3m0=; b=h8rSgfum9BI0+yVoAQxAOA0swombvG767qmFWRMaTOmnWEUWNjDWEQv+Ye4VTw3BEP3WtR TPgbggPEDvQ3tnNM+KfmhlxniKJppzG29I+CboBtFzgst4509kQQ3lxBz8RLv5Nl9HcK2p lRDKxQgEQ0kAHHwyv6jDkwtDhDaeXsY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1779317361; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Wp2ptU7ySVbj8SGonSbemhOk4OytlR4wLpFXI6jr3m0=; b=+mkSH+SyV5BCA6dg2Hy2SToAiZAEY0HsrPoE0XMJ7pq2Bl6iPglnTRzmISVQTzEbC4RJZa fR4XNt8QzNgf2YBQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id B4132593AA; Wed, 20 May 2026 22:49:21 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 445AK3E6DmouUQAAD6G6ig (envelope-from ); Wed, 20 May 2026 22:49:21 +0000 Date: Thu, 21 May 2026 00:49:06 +0200 Message-ID: <87ldddk87x.wl-tiwai@suse.de> From: Takashi Iwai To: "Geoffrey D. Bennett" Cc: Takashi Iwai , Takashi Iwai , linux-sound@vger.kernel.org Subject: Re: [PATCH 0/3] ALSA: scarlett2: Fix 2i2 Gen 4 direct monitor on firmware 2417 In-Reply-To: References: <87cxzkzja7.wl-tiwai@suse.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/30.2 Mule/6.0 Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-Spam-Level: X-Spamd-Result: default: False [-3.30 / 50.00]; BAYES_HAM(-3.00)[100.00%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; RCVD_TLS_ALL(0.00)[]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; FUZZY_RATELIMITED(0.00)[rspamd.com]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; FROM_EQ_ENVFROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:mid,imap1.dmz-prg2.suse.org:helo] X-Spam-Flag: NO X-Spam-Score: -3.30 On Wed, 20 May 2026 22:27:20 +0200, Geoffrey D. Bennett wrote: > > On Mon, Apr 27, 2026 at 02:20:48PM +0200, Takashi Iwai wrote: > > On Sat, 25 Apr 2026 23:07:30 +0200, > > Geoffrey D. Bennett wrote: > > > > > > Hi Takashi, > > > > > > Firmware 2417 for the Scarlett 4th Gen 2i2 moved the direct monitor > > > gain parameters, breaking that control's functionality. > > > > > > The driver already has per-device scarlett2_config_set tables > > > describing each parameter's offset, but only one table per device, so > > > there was no way to express "this offset changed at firmware version > > > N". This series adds that capability and uses it to fix the 2i2 Gen 4. > > > > > > Patches > > > ------- > > > > > > 1/3: Replace the device info's single config_set pointer with a > > > config_sets array of {from_firmware_version, config_set} entries, and > > > resolve the running config_set at probe time once the firmware version > > > has been read. Each device gets a single entry matching its previous > > > min_firmware_version (or 0), so this is a no-op preparation step. > > > > > > 2/3: Drop the now-redundant min_firmware_version field from > > > scarlett2_device_info; config_sets[0].from_firmware_version carries > > > the same meaning. No functional change. > > > > > > 3/3: Add a second 2i2 Gen 4 config_set with DIRECT_MONITOR_GAIN at the > > > new offset, gated on firmware >= 2417. All other offsets are > > > unchanged. > > > > > > Patch 1 is a prerequisite for patch 3. Patch 2 isn't a strict > > > dependency, but it removes a now-redundant field, so patch 3's Cc: > > > stable trailer names both 1 and 2 as prereqs by subject (please > > > substitute SHAs at apply time). Patch 2 can be dropped from the stable > > > backport if you'd prefer. > > > > > > Tested > > > ------ > > > > > > Verified on a Scarlett 2i2 4th Gen by writing to Monitor 1 Mix A Input > > > 01 and observing with usbmon: > > > > > > - Firmware 2128, patched driver: write targets offset 0x2A0 > > > - Firmware 2417, patched driver: write targets offset 0x2A4 > > > - Firmware 2417, unpatched driver: write targets offset 0x2A0 (bug) > > > > > > Regards, > > > Geoffrey > > > > > > Geoffrey D. Bennett (3): > > > ALSA: scarlett2: Allow selecting config_set by firmware version > > > ALSA: scarlett2: Fold min_firmware_version into config_sets > > > ALSA: scarlett2: Update offsets for 2i2 Gen 4 firmware 2417 > > > > Applied all to for-next branch now. Thanks. > > > > > > Takashi > > Hi Takashi, > > This commit is currently queued for 7.2: > > 3ca15754b561 ALSA: scarlett2: Update offsets for 2i2 Gen 4 firmware 2417 > > Users updating to firmware 2417 are hitting broken direct monitor gain > controls, so I wanted to ask if there's any chance of it (and its two > prerequisite commits) making 7.1 & stable now rather than waiting for > the next merge window? The changes are simply too large as a fix for *-rc. If you can work on a reduced simpler fix, I can merge it for 7.1-rc, though. thanks, Takashi