All of lore.kernel.org
 help / color / mirror / Atom feed
From: Baruch Siach via buildroot <buildroot@buildroot.org>
To: Andreas Mohr via buildroot <buildroot@buildroot.org>
Cc: Andreas Mohr <and@gmx.li>,  Pascal de Bruijn <p.debruijn@unilogic.nl>
Subject: Re: [Buildroot] [PATCH v4 1/2] package/libargon2: conditionally shared/static build
Date: Tue, 19 May 2026 06:20:00 +0300	[thread overview]
Message-ID: <87lddgt7a7.fsf@tarshish> (raw)
In-Reply-To: <20260518220229.17936-1-and@gmx.li> (Andreas Mohr via buildroot's message of "Mon, 18 May 2026 22:02:28 +0000")

Hi Andreas,

On Mon, May 18 2026, Andreas Mohr via buildroot wrote:
> Add static build support of libargon2.
> This will allow dependent packages like cryptsetup to build static as well.

The comment in package/cryptsetup/Config.in needs update, then.

Can lua-argon2 build statically now? If not, the comment in its
Config.in pointing at libargon2 needs update as well.

Same goes for python-argon2-cffi-bindings.

baruch

> Signed-off-by: Andreas Mohr <and@gmx.li>
> ---
>  package/libargon2/Config.in    | 5 -----
>  package/libargon2/libargon2.mk | 6 ++++++
>  2 files changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/package/libargon2/Config.in b/package/libargon2/Config.in
> index 6bba74cf..73c1e0d7 100644
> --- a/package/libargon2/Config.in
> +++ b/package/libargon2/Config.in
> @@ -1,12 +1,7 @@
>  config BR2_PACKAGE_LIBARGON2
>  	bool "libargon2"
>  	depends on BR2_USE_MMU
> -	depends on !BR2_STATIC_LIBS
>  	help
>  	  A modern password hashing algorithm
>  
>  	  https://password-hashing.net/#argon2
> -
> -comment "libargon needs a toolchain w/ dynamic library"
> -	depends on BR2_USE_MMU
> -	depends on BR2_STATIC_LIBS
> diff --git a/package/libargon2/libargon2.mk b/package/libargon2/libargon2.mk
> index b3f6e1b2..8ca0071a 100644
> --- a/package/libargon2/libargon2.mk
> +++ b/package/libargon2/libargon2.mk
> @@ -23,6 +23,12 @@ ifeq ($(BR2_TOOLCHAIN_HAS_THREADS),)
>  LIBARGON2_OPTS += NO_THREADS=1
>  endif
>  
> +ifeq ($(BR2_STATIC_LIBS),y)
> +LIBARGON2_OPTS += LIB_SH= LINKED_LIB_SH=
> +else ifeq ($(BR2_SHARED_LIBS),y)
> +LIBARGON2_OPTS += LIB_ST=
> +endif
> +
>  define LIBARGON2_BUILD_CMDS
>  	$(TARGET_MAKE_ENV) $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) \
>  		$(LIBARGON2_OPTS)

-- 
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  parent reply	other threads:[~2026-05-19  3:20 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-18 22:02 [Buildroot] [PATCH v4 1/2] package/libargon2: conditionally shared/static build Andreas Mohr via buildroot
2026-05-18 22:02 ` [Buildroot] [PATCH v4 2/2] package/libargon2: fix pkgconfig version string Andreas Mohr via buildroot
2026-05-20 19:28   ` Arnout Vandecappelle via buildroot
2026-05-29  8:30   ` Thomas Perale via buildroot
2026-05-19  3:20 ` Baruch Siach via buildroot [this message]
2026-05-19 18:43   ` [Buildroot] [PATCH v4 1/2] package/libargon2: conditionally shared/static build Andreas Mohr via buildroot
2026-05-20 19:28     ` Arnout Vandecappelle via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lddgt7a7.fsf@tarshish \
    --to=buildroot@buildroot.org \
    --cc=and@gmx.li \
    --cc=baruch@tkos.co.il \
    --cc=p.debruijn@unilogic.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.