From: Takashi Iwai <tiwai@suse.de>
To: Kailang Yang <kailang@realtek.com>
Cc: Breno Baptista <brenomb07@gmail.com>,
linux-sound@vger.kernel.org, tiwai@suse.com, perex@perex.cz,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: hda/realtek: Restore headset mic after suspend for Acer Nitro 5
Date: Fri, 15 May 2026 08:37:13 +0200 [thread overview]
Message-ID: <87lddluqjq.wl-tiwai@suse.de> (raw)
In-Reply-To: <20260508215746.15564-1-brenomb07@gmail.com>
On Fri, 08 May 2026 23:57:46 +0200,
Breno Baptista wrote:
>
> The headset mic on the AN515-57 was shown as unplugged after resuming
> from S3/S4, requiring a reboot to recover.
>
> Signed-off-by: Breno Baptista <brenomb07@gmail.com>
> ---
> sound/hda/codecs/realtek/alc269.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/alc269.c
> index 11d0ea8ed859..449a5ab3b0d0 100644
> --- a/sound/hda/codecs/realtek/alc269.c
> +++ b/sound/hda/codecs/realtek/alc269.c
> @@ -3578,6 +3578,16 @@ static void alc2xx_fixup_headset_mic(struct hda_codec *codec,
> alc_update_coef_idx(codec, 0x45, 0xf<<12 | 1<<10, 5<<12);
> spec->parse_flags |= HDA_PINCFG_HEADSET_MIC;
> break;
> + case HDA_FIXUP_ACT_INIT:
> + /*
> + * COEF 0x45 (CTIA combo jack mode) is not preserved across suspend.
> + * Restore it before restarting HP JD so the headset is re-detected.
> + */
> + if (is_s3_resume(codec) || is_s4_resume(codec)) {
> + alc_update_coef_idx(codec, 0x45, 0xf<<12 | 1<<10, 5<<12);
> + alc_combo_jack_hp_jd_restart(codec);
> + }
> + break;
> }
> }
The code change itself looks OK, but I'd like to confirm that it's the
expected behavior.
Kailang, could you verify this please?
thanks,
Takashi
prev parent reply other threads:[~2026-05-15 6:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-08 21:57 [PATCH] ALSA: hda/realtek: Restore headset mic after suspend for Acer Nitro 5 Breno Baptista
2026-05-15 6:37 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lddluqjq.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=brenomb07@gmail.com \
--cc=kailang@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.