All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Cc: mst@redhat.com,  sgarzare@redhat.com,  qemu-devel@nongnu.org,
	d-tatianin@yandex-team.ru,  Eric Blake <eblake@redhat.com>
Subject: Re: [PATCH v2 06/10] qapi: remove user addresses from x-query-virtio-vhost-queue-status
Date: Fri, 24 Apr 2026 08:31:40 +0200	[thread overview]
Message-ID: <87ldecx41f.fsf@pond.sub.org> (raw)
In-Reply-To: <20260420202032.714884-7-vsementsov@yandex-team.ru> (Vladimir Sementsov-Ogievskiy's message of "Mon, 20 Apr 2026 23:20:27 +0300")

Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru> writes:

> Semantics of these (actually, internal) fields is not simple, they may
> contain either virtual or physical addresses. We are going to change
> this to simplify the logic. Keeping this logic only for unstable
> info command seems too much. Changing semantics of info fields doesn't
> seem to make real sense too. So, let's just drop them. We can dot it,

s/dot/do/

> as command is experimental.

Nitpick: the schema has

    # @unstable: This command is meant for debugging.

Suggest "as the command is unstable".

> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>

QAPI schema
Acked-by: Markus Armbruster <armbru@redhat.com>



  reply	other threads:[~2026-04-24  6:33 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-20 20:20 [PATCH v2 00/10] vhost-user: VHOST_USER_PROTOCOL_F_GPA_ADDRESSES Vladimir Sementsov-Ogievskiy
2026-04-20 20:20 ` [PATCH v2 01/10] vhost: move IOTLB functions from vhost-backend.c to vhost.c Vladimir Sementsov-Ogievskiy
2026-04-20 20:20 ` [PATCH v2 02/10] vhost: use consistent naming for backend handlers Vladimir Sementsov-Ogievskiy
2026-04-20 20:20 ` [PATCH v2 03/10] vhost: rename vhost-backend.c to vhost-kernel.c Vladimir Sementsov-Ogievskiy
2026-04-20 20:20 ` [PATCH v2 04/10] vhost: replace .vhost_vq_get_addr() with .vhost_phys_vring_addr() Vladimir Sementsov-Ogievskiy
2026-04-20 20:20 ` [PATCH v2 05/10] vhost: simplify vhost_memory_map() and vhost_memory_unmap() Vladimir Sementsov-Ogievskiy
2026-04-20 20:20 ` [PATCH v2 06/10] qapi: remove user addresses from x-query-virtio-vhost-queue-status Vladimir Sementsov-Ogievskiy
2026-04-24  6:31   ` Markus Armbruster [this message]
2026-04-20 20:20 ` [PATCH v2 07/10] vhost: stop reusing vq->desc (and friends) to store physical address Vladimir Sementsov-Ogievskiy
2026-04-20 20:20 ` [PATCH v2 08/10] vhost: rename vring pointer fields to reflect user addresses Vladimir Sementsov-Ogievskiy
2026-04-20 20:20 ` [PATCH v2 09/10] vhost: add .vhost_phys_iotlb_msg() handler Vladimir Sementsov-Ogievskiy
2026-04-20 20:20 ` [PATCH v2 10/10] vhost-user: add VHOST_USER_PROTOCOL_F_GPA_ADDRESSES Vladimir Sementsov-Ogievskiy
2026-05-05 10:23 ` [PATCH v2 00/10] vhost-user: VHOST_USER_PROTOCOL_F_GPA_ADDRESSES Vladimir Sementsov-Ogievskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ldecx41f.fsf@pond.sub.org \
    --to=armbru@redhat.com \
    --cc=d-tatianin@yandex-team.ru \
    --cc=eblake@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=sgarzare@redhat.com \
    --cc=vsementsov@yandex-team.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.