All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Faye <faye.opensource@gmail.com>
Cc: alsa-devel@alsa-project.org, tiwai@suse.com, perex@perex.cz,
	linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: hda/realtek: Add quirk for Acer PT316-51S headset mic
Date: Mon, 13 Apr 2026 07:36:01 +0200	[thread overview]
Message-ID: <87lderwhfi.wl-tiwai@suse.de> (raw)
In-Reply-To: <20260413031259.30135-1-faye.opensource@gmail.com>

On Mon, 13 Apr 2026 05:12:59 +0200,
Faye wrote:
> 
> The Acer PT316-51S (PCI SSID 1025:160e) with ALC287 codec does not
> detect the headset microphone due to missing BIOS pin configuration
> for pin 0x19. Apply ALC2XX_FIXUP_HEADSET_MIC to enable it.
> 
> Signed-off-by: Faye <faye.opensource@gmail.com>

Signed-off-by tag needs to be a real name (or a known identity) as
it's a legal requirement (and preferably From tag should be same,
too).

Also...

> ---
>  sound/hda/codecs/realtek/alc269.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/alc269.c
> index cb39054..75466f4 100644
> --- a/sound/hda/codecs/realtek/alc269.c
> +++ b/sound/hda/codecs/realtek/alc269.c
> @@ -6689,6 +6689,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
>  	SND_PCI_QUIRK(0x1025, 0x1534, "Acer Predator PH315-54", ALC255_FIXUP_ACER_MIC_NO_PRESENCE),
>  	SND_PCI_QUIRK(0x1025, 0x1539, "Acer Nitro 5 AN515-57", ALC2XX_FIXUP_HEADSET_MIC),
>  	SND_PCI_QUIRK(0x1025, 0x159c, "Acer Nitro 5 AN515-58", ALC2XX_FIXUP_HEADSET_MIC),
> +	SND_PCI_QUIRK(0x1025, 0x160e, "Acer PT316-51S", ALC2XX_FIXUP_HEADSET_MIC),
>  	SND_PCI_QUIRK(0x1025, 0x1597, "Acer Nitro 5 AN517-55", ALC2XX_FIXUP_HEADSET_MIC),
>  	SND_PCI_QUIRK(0x1025, 0x169a, "Acer Swift SFG16", ALC256_FIXUP_ACER_SFG16_MICMUTE_LED),
>  	SND_PCI_QUIRK(0x1025, 0x171e, "Acer Nitro ANV15-51", ALC245_FIXUP_ACER_MICMUTE_LED),

... the table is sorted in PCI SSID order.  Please put the new entry
at the right position.

Could you resubmit with the above corrections?


thanks,

Takashi

  reply	other threads:[~2026-04-13  5:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-13  3:12 [PATCH] ALSA: hda/realtek: Add quirk for Acer PT316-51S headset mic Faye
2026-04-13  5:36 ` Takashi Iwai [this message]
2026-04-13 21:20   ` Faye
2026-04-14  7:19     ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lderwhfi.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=faye.opensource@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.