All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: "Leonard Lausen" <leonard@lausen.nl>
Cc: sbinding@opensource.cirrus.com, david.rhodes@cirrus.com,
	rf@opensource.cirrus.com, perex@perex.cz, tiwai@suse.com,
	linux-sound@vger.kernel.org, patches@opensource.cirrus.com,
	linux-kernel@vger.kernel.org, me@nicho1as.wang
Subject: Re: [PATCH] ALSA: hda: cs35l41: Fix boost type for HP Dragonfly 13.5    inch G4
Date: Mon, 30 Mar 2026 18:25:20 +0200	[thread overview]
Message-ID: <87ldf9thcf.wl-tiwai@suse.de> (raw)
In-Reply-To: <db84dcf91bc8dbd217b35572b177d967655ff903@lausen.nl>

On Fri, 27 Mar 2026 23:25:15 +0100,
Leonard Lausen wrote:
> 
> The HP Dragonfly 13.5 inch G4 (SSID 103C8B63) has _DSD properties in
> ACPI firmware with valid reset-gpios and cs-gpios for the four CS35L41
> amplifiers on SPI.
> 
> However, the _DSD specifies cirrus,boost-type as Internal (0), while
> the hardware requires External Boost. With Internal Boost configured,
> the amplifiers trigger "Amp short error" when audio is played at
> moderate-to-high volume, eventually shutting down entirely.
> 
> Add a configuration table entry to override the boost type to
> External, similar to the existing workaround for 103C89C6. All GPIO
> indices are set to -1 since the _DSD provides valid reset-gpios and
> cs-gpios.
> 
> Confirmed on BIOS V90 01.11.00 (January 2026), the latest available.
> 
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=219520
> Originally-by: Nicholas Wang <me@nicho1as.wang>
> Signed-off-by: Leonard Lausen <leonard@lausen.nl>
> ---
> This is a reworked version of Nicholas Wang's patch from Nov 2024 [1].
> Stefan Binding noted that this laptop should have valid _DSD.
> 
> Analysis of the ACPI DSDT confirms the _DSD exists with valid
> reset-gpios, cs-gpios, and cirrus,speaker-position. However,
> cirrus,boost-type is set to 0 (Internal) while the hardware requires
> External Boost. The cs35l41_hda_parse_acpi() fallback also gets this
> wrong since it infers Internal from the non-zero boost parameters.
> 
> With Internal Boost, all four amps hit "Amp short error" at
> moderate volume. Overriding to External Boost (like 103C89C6)
> resolves the issue. GPIO indices are set to -1 since the _DSD
> provides valid reset-gpios and cs-gpios, addressing Stefan's
> concern about cs_gpio_index.
> 
> Tested on BIOS V90 01.11.00 (Jan 2026, latest available from HP).

Applied to for-next branch now.


thanks,

Takashi

      reply	other threads:[~2026-03-30 16:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-27 22:25 [PATCH] ALSA: hda: cs35l41: Fix boost type for HP Dragonfly 13.5 inch G4 Leonard Lausen
2026-03-30 16:25 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ldf9thcf.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=david.rhodes@cirrus.com \
    --cc=leonard@lausen.nl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=me@nicho1as.wang \
    --cc=patches@opensource.cirrus.com \
    --cc=perex@perex.cz \
    --cc=rf@opensource.cirrus.com \
    --cc=sbinding@opensource.cirrus.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.