From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Matt Roper <matthew.d.roper@intel.com>
Cc: <intel-xe@lists.freedesktop.org>,
Michal Wajdeczko <michal.wajdeczko@intel.com>,
Harish Chegondi <harish.chegondi@intel.com>
Subject: Re: [PATCH v4 1/4] drm/xe/reg_sr: Don't process gt/hwe lists in VF
Date: Wed, 18 Feb 2026 14:55:32 -0800 [thread overview]
Message-ID: <87ldgpwtjv.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <20260218-sr_verify-v4-1-35d6deeb3421@intel.com>
On Wed, 18 Feb 2026 14:09:12 -0800, Matt Roper wrote:
>
> diff --git a/drivers/gpu/drm/xe/xe_rtp.c b/drivers/gpu/drm/xe/xe_rtp.c
> index b7c26e2fb411ea75fbd484b55f48019fc09f0581..7bfdc6795ce6fd3d2c8c9d1398c7b72ff476b96d 100644
> --- a/drivers/gpu/drm/xe/xe_rtp.c
> +++ b/drivers/gpu/drm/xe/xe_rtp.c
> @@ -270,6 +270,8 @@ static void rtp_mark_active(struct xe_device *xe,
> * @sr: Save-restore struct where matching rules execute the action. This can be
> * viewed as the "coalesced view" of multiple the tables. The bits for each
> * register set are expected not to collide with previously added entries
> + * @process_in_vf: Whether this RTP table should get processed for SR-IOV VF
> + * devices. Should generally only be 'true' for LRC tables.
> *
> * Walk the table pointed by @entries (with an empty sentinel) and add all
> * entries with matching rules to @sr. If @hwe is not NULL, its mmio_base is
> @@ -278,7 +280,8 @@ static void rtp_mark_active(struct xe_device *xe,
> void xe_rtp_process_to_sr(struct xe_rtp_process_ctx *ctx,
> const struct xe_rtp_entry_sr *entries,
> size_t n_entries,
> - struct xe_reg_sr *sr)
> + struct xe_reg_sr *sr,
> + bool process_in_vf)
Another idea would be to change 'process_in_vf' to something like
'is_lrc'. But otherwise ok as is too (specially if some non-lrc cases need
to be processed in VF's in the future):
Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
> {
> const struct xe_rtp_entry_sr *entry;
> struct xe_hw_engine *hwe = NULL;
> @@ -287,6 +290,9 @@ void xe_rtp_process_to_sr(struct xe_rtp_process_ctx *ctx,
>
> rtp_get_context(ctx, &hwe, >, &xe);
>
> + if (!process_in_vf && IS_SRIOV_VF(xe))
> + return;
> +
next prev parent reply other threads:[~2026-02-18 22:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-18 22:09 [PATCH v4 0/4] Add debugfs facility to catch RTP mistakes Matt Roper
2026-02-18 22:09 ` [PATCH v4 1/4] drm/xe/reg_sr: Don't process gt/hwe lists in VF Matt Roper
2026-02-18 22:55 ` Dixit, Ashutosh [this message]
2026-02-18 22:09 ` [PATCH v4 2/4] drm/xe/reg_sr: Add debugfs to verify status of reg_sr programming Matt Roper
2026-02-18 22:09 ` [PATCH v4 3/4] drm/xe: Add facility to lookup the value of a register in a default LRC Matt Roper
2026-02-19 2:23 ` Dixit, Ashutosh
2026-02-18 22:09 ` [PATCH v4 4/4] drm/xe/reg_sr: Allow register_save_restore_check debugfs to verify LRC values Matt Roper
2026-02-19 2:23 ` Dixit, Ashutosh
2026-02-18 22:52 ` ✓ CI.KUnit: success for Add debugfs facility to catch RTP mistakes (rev3) Patchwork
2026-02-18 23:28 ` ✓ Xe.CI.BAT: " Patchwork
2026-02-19 0:30 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-02-19 15:36 ` Matt Roper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ldgpwtjv.wl-ashutosh.dixit@intel.com \
--to=ashutosh.dixit@intel.com \
--cc=harish.chegondi@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=matthew.d.roper@intel.com \
--cc=michal.wajdeczko@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.