From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 748C6D74EC8 for ; Fri, 23 Jan 2026 13:23:41 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vjH8S-0000zq-Nf; Fri, 23 Jan 2026 08:23:36 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vjH8R-0000uY-D5 for qemu-devel@nongnu.org; Fri, 23 Jan 2026 08:23:35 -0500 Received: from smtp-out1.suse.de ([2a07:de40:b251:101:10:150:64:1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vjH8P-0001ny-Vk for qemu-devel@nongnu.org; Fri, 23 Jan 2026 08:23:35 -0500 Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id C2E91337E1; Fri, 23 Jan 2026 13:23:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1769174612; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZSxwWd0bWIrCejqnR0+In1Xfhza7YA79sD/F4GaPruE=; b=S16C3fGYYEbMojrsv1YFbmLQgV591tyK0VlFmia8+GpX3jNeHjGZ7ogaZFAuSVGiyy+IXX 8NLjEfuS867Jo7/faWxjuhHUOWxjrPqlMP84crWiQrutHCQPcPJhqvkHSSoKrmBr5XkBDt j3Bf4VfrPgkBxcDcxawjwtV0GhrLlas= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1769174612; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZSxwWd0bWIrCejqnR0+In1Xfhza7YA79sD/F4GaPruE=; b=KDLNYoY8TX4kZ8D/QkHrX8oVSIOgufOXWyNzFCSiBM6ZpmWMmhWgVjGyYYqfi5QlRf2li+ RsE/CZHGzyJoCmDw== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1769174612; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZSxwWd0bWIrCejqnR0+In1Xfhza7YA79sD/F4GaPruE=; b=S16C3fGYYEbMojrsv1YFbmLQgV591tyK0VlFmia8+GpX3jNeHjGZ7ogaZFAuSVGiyy+IXX 8NLjEfuS867Jo7/faWxjuhHUOWxjrPqlMP84crWiQrutHCQPcPJhqvkHSSoKrmBr5XkBDt j3Bf4VfrPgkBxcDcxawjwtV0GhrLlas= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1769174612; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZSxwWd0bWIrCejqnR0+In1Xfhza7YA79sD/F4GaPruE=; b=KDLNYoY8TX4kZ8D/QkHrX8oVSIOgufOXWyNzFCSiBM6ZpmWMmhWgVjGyYYqfi5QlRf2li+ RsE/CZHGzyJoCmDw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 3449F136AA; Fri, 23 Jan 2026 13:23:31 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id tttfOVN2c2nyZAAAD6G6ig (envelope-from ); Fri, 23 Jan 2026 13:23:31 +0000 From: Fabiano Rosas To: Peter Xu , qemu-devel@nongnu.org Cc: Prasad Pandit , Lukas Straub , Juraj Marcin , peterx@redhat.com Subject: Re: [PATCH 02/10] migration: Use qemu_savevm_send_header() in qemu_save_device_state() In-Reply-To: <20260121223336.3381912-3-peterx@redhat.com> References: <20260121223336.3381912-1-peterx@redhat.com> <20260121223336.3381912-3-peterx@redhat.com> Date: Fri, 23 Jan 2026 10:23:29 -0300 Message-ID: <87ldhoihta.fsf@suse.de> MIME-Version: 1.0 Content-Type: text/plain X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MISSING_XM_UA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; MIME_TRACE(0.00)[0:+]; TO_DN_SOME(0.00)[]; RCVD_TLS_ALL(0.00)[]; ARC_NA(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; FREEMAIL_ENVRCPT(0.00)[web.de]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_HAS_DN(0.00)[]; FREEMAIL_CC(0.00)[redhat.com,web.de]; RCPT_COUNT_FIVE(0.00)[6]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:mid, suse.de:email, imap1.dmz-prg2.suse.org:helo] Received-SPF: pass client-ip=2a07:de40:b251:101:10:150:64:1; envelope-from=farosas@suse.de; helo=smtp-out1.suse.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Peter Xu writes: > Reduces duplication of the other path where we also send the same header. > > Signed-off-by: Peter Xu > --- > migration/savevm.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/migration/savevm.c b/migration/savevm.c > index e26656cca3..64bf445c98 100644 > --- a/migration/savevm.c > +++ b/migration/savevm.c > @@ -1872,8 +1872,7 @@ int qemu_save_device_state(QEMUFile *f) > SaveStateEntry *se; > > if (!migration_in_colo_state()) { > - qemu_put_be32(f, QEMU_VM_FILE_MAGIC); > - qemu_put_be32(f, QEMU_VM_FILE_VERSION); > + qemu_savevm_send_header(f); > } > cpu_synchronize_all_states(); Reviewed-by: Fabiano Rosas