From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A962225783A for ; Wed, 7 Jan 2026 04:58:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767761904; cv=none; b=GJ1zcyTaVWB8p+pt+IE/enqSz03v7AqpZHquTJprOyRt88CKMZsZow3FDn6YEUnLIGTCwQXQ8eKqVuXv/089FBy9GKUXM48m0+AmqhGk+7yRPXaB3nPUbiRevv12rMQ21aEd1HGbI21CVEC+Q6mgCDQRKeh+TfhZPt+nr01KVMc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767761904; c=relaxed/simple; bh=u52IYXtkIGi8sisrJ2GXaZQiFovGjOBhfJtTiCU+FIM=; h=From:To:Cc:Subject:In-Reply-To:Date:Message-ID:References: MIME-Version:Content-Type; b=WOX6jIUJGg12PfiVl9JMLOyRCkNBVc3nFdpKAlzJor9AhLKlvNJGLbhVry5BWcr8IkU6Madz9CB9oC01U3l2SNK878hht2hfmRFC6PS7AHjMl5rVi0QYMmJ7XZ4G1eGehzPHFWK3zrH2qrGPpjOt2hvUnIPFnH+4ytGv4FZRuVM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XE9OHB7K; arc=none smtp.client-ip=209.85.216.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XE9OHB7K" Received: by mail-pj1-f43.google.com with SMTP id 98e67ed59e1d1-34c1d98ba11so1480142a91.3 for ; Tue, 06 Jan 2026 20:58:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767761902; x=1768366702; darn=vger.kernel.org; h=mime-version:references:message-id:date:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=nurUXHNs091EaceKYt0jtxQiBJ2IaAdTDr7CGJ+zWBU=; b=XE9OHB7Kl+IegOavGwsCniq7IfH569pyWSwOB3GH4IFakEzMoVU0qTAM99Htm/LTZa oIrdXqofABAYlYf0vbgd+n0GUNiJzVIPiyO8CScU6yhPMURk/UDM/RVMGFEztgjtLPNS WRPiIEJnD0Ff9/Z8WNMKc7Anw6/nMx8MAbq3s3xv9xn+5m1oNJCX1ktobB6O3+C+tCKf 0dT43+gSNEm71HVEC9CZgI8klLsPbgoiQqrHQwigH/O6I0GQ3Ti8owh0piXgvhZN4xe2 1m7D9Rr/nZ33sxwqrbUB/YINiEIurizt1znhUcLNHdGYLs9ErvXCDeFUGjhnGu4pVoK6 wLTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767761902; x=1768366702; h=mime-version:references:message-id:date:in-reply-to:subject:cc:to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=nurUXHNs091EaceKYt0jtxQiBJ2IaAdTDr7CGJ+zWBU=; b=KUc0Cfol6VIBS9kZGnkm8vB1x9INypvAxZnTbOu4oVmVLhqEQUlwrktx6wzkbF0skY QESBxAS+cNu6sFwfmfc3xQJCjlhYLaGve0cRon4Rkaqnc16BzNUOnBVAHa2T+R8JetlO GZDssx8Ew3o9/E8p1cwxrWDuPiD9i+hpS6BO0fcOaDrGkZ4oFtZXsnGSgHMng5VmdnA3 HIKyd0fnUJwnB1f5ZsfdkXV/UmseFRwgJMAe+8lKDT55oaCm3i7ThLNztJL0UVWYpFVE 3HZC3pD86Dq0HgWxfbJZD/lv5pc357nOJin5FnJU/89vvPVzqryjclMYgJnuJnw9OGj7 vq0w== X-Forwarded-Encrypted: i=1; AJvYcCV0HvpXZtloW7JHBRBw+gfDL1/BH4KkyO+8g25e93WKo7JKdY27BNz0bzuH9a5RryRrtLneV4hUUP4j2A==@vger.kernel.org X-Gm-Message-State: AOJu0YxkkOBi2RZpt2qERAcuM7bs2JJ/O4GDOprdaVOH5oqHKBSyWWrx f1Q1Is7GjI6gLBjOawAhC2iVvMOQHoqpScEddsm40aAMZOIdb7Q7hqBh X-Gm-Gg: AY/fxX621Ez6pALzdbPNIvUFx1J2z5qAqnZWNSJR/lXNDyINWDbVkPgAt6LiD87QDcd +VFmceBQWpZ1bWWSW02HNkWRJuVUJ+8qJHmCZ64ShDM7bEX9HVGa1e/qXFAWwHGMpTSYwy+FU3H tNvcnWMUJ9CL5VAleQVUPmW4YKsnZ7Lhmsz4ZFtoEmVwx0HhvRYwWojKcPeAuDovELAQCzFE9Pc 9tfSMjrTeaWd809PlT4DXaSwOCduS7cdSKqsunkHy3Y/pS9puOoA9KiKog9QfeL1NvpySToRfRb eTITlryyMN2J+Rvso2SXVTNEjT6k6gQHyLR0vPgu3y6XbrsYid9knrvdLkaUksQqw7leGgm7rMZ HspidzDU8+5d4ffOlWTUGIJo9FTfFhMaa70G0v6AszMAyItYvvtX83kPbLlYWMLC7fR2MpI/gFx hsEXTflw== X-Google-Smtp-Source: AGHT+IE3iEJ4twso46GOnqJPDopUox2qFLaKHiDPKI95vlPPxjV/F7mxvaI/CeOE2s8GrRHRScEd6Q== X-Received: by 2002:a17:90b:6c7:b0:335:2eef:4ca8 with SMTP id 98e67ed59e1d1-34f68d3b4a4mr1191743a91.33.1767761901762; Tue, 06 Jan 2026 20:58:21 -0800 (PST) Received: from dw-tp ([49.207.192.172]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-34f5fb75902sm3622895a91.16.2026.01.06.20.58.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Jan 2026 20:58:20 -0800 (PST) From: Ritesh Harjani (IBM) To: Mike Rapoport , Andrew Morton Cc: Alex Shi , Alexander Gordeev , Andreas Larsson , Borislav Petkov , Brian Cain , "Christophe Leroy (CS GROUP)" , Catalin Marinas , "David S. Miller" , Dave Hansen , David Hildenbrand , Dinh Nguyen , Geert Uytterhoeven , Guo Ren , Heiko Carstens , Helge Deller , Huacai Chen , Ingo Molnar , Johannes Berg , John Paul Adrian Glaubitz , Jonathan Corbet , "Liam R. Howlett" , Lorenzo Stoakes , Magnus Lindholm , Matt Turner , Max Filippov , Michael Ellerman , Michal Hocko , Michal Simek , Mike Rapoport , Muchun Song , Oscar Salvador , Palmer Dabbelt , Pratyush Yadav , Richard Weinberger , Russell King , Stafford Horne , Suren Baghdasaryan , Thomas Bogendoerfer , Thomas Gleixner , Vasily Gorbik , Vineet Gupta , Vlastimil Babka , Will Deacon , x86@kernel.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-cxl@vger.kernel.org, linux-doc@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-openrisc@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-um@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, sparclinux@vger.kernel.org Subject: Re: [PATCH v2 14/28] powerpc: introduce arch_zone_limits_init() In-Reply-To: <20260102070005.65328-15-rppt@kernel.org> Date: Wed, 07 Jan 2026 09:57:34 +0530 Message-ID: <87ldia9he1.ritesh.list@gmail.com> References: <20260102070005.65328-1-rppt@kernel.org> <20260102070005.65328-15-rppt@kernel.org> Precedence: bulk X-Mailing-List: linux-alpha@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Mike Rapoport writes: > From: "Mike Rapoport (Microsoft)" > > Move calculations of zone limits to a dedicated arch_zone_limits_init() > function. > > Later MM core will use this function as an architecture specific callback > during nodes and zones initialization and thus there won't be a need to > call free_area_init() from every architecture. > > Signed-off-by: Mike Rapoport (Microsoft) > --- > arch/powerpc/mm/mem.c | 22 ++++++++++++---------- > 1 file changed, 12 insertions(+), 10 deletions(-) > > diff --git a/arch/powerpc/mm/mem.c b/arch/powerpc/mm/mem.c > index 3ddbfdbfa941..32c496bfab4f 100644 > --- a/arch/powerpc/mm/mem.c > +++ b/arch/powerpc/mm/mem.c > @@ -221,13 +221,23 @@ static int __init mark_nonram_nosave(void) > * anyway) will take a first dip into ZONE_NORMAL and get otherwise served by > * ZONE_DMA. > */ > -static unsigned long max_zone_pfns[MAX_NR_ZONES]; > +void __init arch_zone_limits_init(unsigned long *max_zone_pfns) > +{ > +#ifdef CONFIG_ZONE_DMA > + max_zone_pfns[ZONE_DMA] = min(zone_dma_limit, max_low_pfn - 1) + 1; Hi Mike, This doesn't look correct. Isn't the zone_dma_limit value in bytes actually? Shouldn't it be - max_zone_pfns[ZONE_DMA] = min((zone_dma_limit >> PAGE_SHIFT) + 1, max_low_pfn); -ritesh > +#endif > + max_zone_pfns[ZONE_NORMAL] = max_low_pfn; > +#ifdef CONFIG_HIGHMEM > + max_zone_pfns[ZONE_HIGHMEM] = max_pfn; > +#endif > +} > > /* > * paging_init() sets up the page tables - in fact we've already done this. > */ > void __init paging_init(void) > { > + unsigned long max_zone_pfns[MAX_NR_ZONES]; > unsigned long long total_ram = memblock_phys_mem_size(); > phys_addr_t top_of_ram = memblock_end_of_DRAM(); > int zone_dma_bits; > @@ -259,15 +269,7 @@ void __init paging_init(void) > > zone_dma_limit = DMA_BIT_MASK(zone_dma_bits); > > -#ifdef CONFIG_ZONE_DMA > - max_zone_pfns[ZONE_DMA] = min(max_low_pfn, > - 1UL << (zone_dma_bits - PAGE_SHIFT)); > -#endif > - max_zone_pfns[ZONE_NORMAL] = max_low_pfn; > -#ifdef CONFIG_HIGHMEM > - max_zone_pfns[ZONE_HIGHMEM] = max_pfn; > -#endif > - > + arch_zone_limits_init(max_zone_pfns); > free_area_init(max_zone_pfns); > > mark_nonram_nosave(); > -- > 2.51.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 947E9CF6BEB for ; Wed, 7 Jan 2026 04:58:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:Message-ID:Date :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LhtnWAXErGKFaNDaTpKwu7ujaIR8inxWAO7jkknGBeI=; b=piVszEG2NQVMFL WMkTdjcmpY/zVI52ydxBoyBliEuU4DMok5Aa6YjnRlwk4I04B57jggNKYGJnl2qxtMvOsYl9/9FlU Drp2o6qqWGc0HmEns9meWKkoWeQ+vaOBYLiwI9WeimqZM+2tfzLy1R5RwluKrryZMfdzxFsMrASmM pKR1FWVfsYgYHNfABULsKI+Nm3TR0a3zHdCYN/RZ6DdFdE3VWH+HDbiktyaDk/GePn+aZLmOHWZXj 056LT8vkwdjdRbadOKKKVY4SWpGwRbjNulQxBf4D0DSTTh11fXVLWcV+Qb9cupA/DDl3GIXKqn9YJ 9Ed4UkTNsH/V6JktFnWQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vdLco-0000000EAHT-28P0; Wed, 07 Jan 2026 04:58:26 +0000 Received: from mail-pj1-x102c.google.com ([2607:f8b0:4864:20::102c]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vdLcl-0000000EAG5-1jBH for linux-riscv@lists.infradead.org; Wed, 07 Jan 2026 04:58:24 +0000 Received: by mail-pj1-x102c.google.com with SMTP id 98e67ed59e1d1-34c9edf63a7so1496591a91.1 for ; Tue, 06 Jan 2026 20:58:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767761902; x=1768366702; darn=lists.infradead.org; h=mime-version:references:message-id:date:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=nurUXHNs091EaceKYt0jtxQiBJ2IaAdTDr7CGJ+zWBU=; b=aKqe1+Hs5jYE9MkwLcrTKlJLIw85Lxti/5NndB7CuRNr4YucpZ76yw68w6mVpc7/ZR rAXSpDMV0nsS6Bc49HZ1FPK+ufBBSpn6JNVB7Gc6fiJdsHsOIVIhN3op2toCQXzeBT6F b9GNIV18ETHRWjWwZf7TUH2/JgyOpkM1SVIIov5TiA6qNBoKrVz5U7Rr3AJ0xsgSGcNh A1Q0558A19ZV/0E41l9+J31KFGbkMuTJMI/sfIDVeFZOuDuC/jPbh6DmuzaJ/9XtnYh/ 4AZykFqOMV2OjHOyijx9fATpG2D2edz1BS1NlRoP3L4kcWnFRYR/vJ5vp3izM744JGU6 9kFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767761902; x=1768366702; h=mime-version:references:message-id:date:in-reply-to:subject:cc:to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=nurUXHNs091EaceKYt0jtxQiBJ2IaAdTDr7CGJ+zWBU=; b=I9zaQWZquU/PGcePi6ktM+nj29UbJBCEd9dXmz27RI+jyXKPIyt07uEsTCloUeVRZ4 5oyTn79MoPHVYi8qd5pSLR0sIRZJ2ByHLTlkaftvhs2MSpAOVpClfLLcaf7yTwWfsZwk SdKhMyKroMgsYWSFoDD9r0FvFqHNJ6FqBfY6e4o2xsmEP7MNFSJ6paF2O84dSRjQ7mkj cvFwdCzU5C2Ueys6FvekXjQozjnhWQ7CBJCyIu7EZzI/0fudTBuNnWlBHAP9ksYMqe0W qEzbCGlXn97k1rxHmvPVUvQx81lWaBkdw+kjcehqybJUroGinqa0Vx4fUN5SFJmoqAhe cgYA== X-Forwarded-Encrypted: i=1; AJvYcCWg0W5lHrvYOlqOCYZYCl2SnV6KJ1/lOGs+8jdUUPbEPMIGo/HASIsU8YzJkbpuA/ALqnoZxsREBOjWdw==@lists.infradead.org X-Gm-Message-State: AOJu0YyN+bSbeJMMVvNfy8ob2VCDRvCwmfv2WG4/xxnYE4HPBwmRH7x+ ySHy3JHcvAXsOwg9i9mmAsRofBJcETSQ35NmfW58G4AlFj7OcD9e8OLH X-Gm-Gg: AY/fxX7ao37NmftMRjEPRWBonA++fKbvtwsTGEa/1dzrHvrND26h2lm2RxSjAPP4hoW 85IgEtCZjx9sr9/STb9/8MzAmbm8XNy7/WvMcTny8gniMB4N+d7EGY7JEGFSpvHodcg6udCjuMa YxnWRNH7ZebdNF9ikS2bng7V+VvNDtoXhRvLyp0GWR6QMv1V9RP+rBjDx5Lc+GDVe8sS8qUB7xT dZxUmwzNjmQe6i4muyrxWlrVpmHFRKyZ6qyxCe7MhUN/Qu1Pi8GXbL7XcRsL3frFJlKTG6Ee0DS TuOPo0AGrDDe+744sTvThuCtUhI0IoZ2DN+Ko1bjgh3hjZcfkjjsg1gpO5yElTGTSm8TUI782T1 MYH5lB6CZNqM+8g0s9zjfL7TddJsatdwz1JNQ3Y7cIoMYtohPmKcLK5T0yWFR1CAs+Okmq9QbGc touSH6Hg== X-Google-Smtp-Source: AGHT+IE3iEJ4twso46GOnqJPDopUox2qFLaKHiDPKI95vlPPxjV/F7mxvaI/CeOE2s8GrRHRScEd6Q== X-Received: by 2002:a17:90b:6c7:b0:335:2eef:4ca8 with SMTP id 98e67ed59e1d1-34f68d3b4a4mr1191743a91.33.1767761901762; Tue, 06 Jan 2026 20:58:21 -0800 (PST) Received: from dw-tp ([49.207.192.172]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-34f5fb75902sm3622895a91.16.2026.01.06.20.58.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Jan 2026 20:58:20 -0800 (PST) From: Ritesh Harjani (IBM) To: Mike Rapoport , Andrew Morton Cc: Alex Shi , Alexander Gordeev , Andreas Larsson , Borislav Petkov , Brian Cain , "Christophe Leroy (CS GROUP)" , Catalin Marinas , "David S. Miller" , Dave Hansen , David Hildenbrand , Dinh Nguyen , Geert Uytterhoeven , Guo Ren , Heiko Carstens , Helge Deller , Huacai Chen , Ingo Molnar , Johannes Berg , John Paul Adrian Glaubitz , Jonathan Corbet , "Liam R. Howlett" , Lorenzo Stoakes , Magnus Lindholm , Matt Turner , Max Filippov , Michael Ellerman , Michal Hocko , Michal Simek , Mike Rapoport , Muchun Song , Oscar Salvador , Palmer Dabbelt , Pratyush Yadav , Richard Weinberger , Russell King , Stafford Horne , Suren Baghdasaryan , Thomas Bogendoerfer , Thomas Gleixner , Vasily Gorbik , Vineet Gupta , Vlastimil Babka , Will Deacon , x86@kernel.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-cxl@vger.kernel.org, linux-doc@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-openrisc@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-um@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, sparclinux@vger.kernel.org Subject: Re: [PATCH v2 14/28] powerpc: introduce arch_zone_limits_init() In-Reply-To: <20260102070005.65328-15-rppt@kernel.org> Date: Wed, 07 Jan 2026 09:57:34 +0530 Message-ID: <87ldia9he1.ritesh.list@gmail.com> References: <20260102070005.65328-1-rppt@kernel.org> <20260102070005.65328-15-rppt@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260106_205823_444360_70426FF2 X-CRM114-Status: GOOD ( 18.89 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org Mike Rapoport writes: > From: "Mike Rapoport (Microsoft)" > > Move calculations of zone limits to a dedicated arch_zone_limits_init() > function. > > Later MM core will use this function as an architecture specific callback > during nodes and zones initialization and thus there won't be a need to > call free_area_init() from every architecture. > > Signed-off-by: Mike Rapoport (Microsoft) > --- > arch/powerpc/mm/mem.c | 22 ++++++++++++---------- > 1 file changed, 12 insertions(+), 10 deletions(-) > > diff --git a/arch/powerpc/mm/mem.c b/arch/powerpc/mm/mem.c > index 3ddbfdbfa941..32c496bfab4f 100644 > --- a/arch/powerpc/mm/mem.c > +++ b/arch/powerpc/mm/mem.c > @@ -221,13 +221,23 @@ static int __init mark_nonram_nosave(void) > * anyway) will take a first dip into ZONE_NORMAL and get otherwise served by > * ZONE_DMA. > */ > -static unsigned long max_zone_pfns[MAX_NR_ZONES]; > +void __init arch_zone_limits_init(unsigned long *max_zone_pfns) > +{ > +#ifdef CONFIG_ZONE_DMA > + max_zone_pfns[ZONE_DMA] = min(zone_dma_limit, max_low_pfn - 1) + 1; Hi Mike, This doesn't look correct. Isn't the zone_dma_limit value in bytes actually? Shouldn't it be - max_zone_pfns[ZONE_DMA] = min((zone_dma_limit >> PAGE_SHIFT) + 1, max_low_pfn); -ritesh > +#endif > + max_zone_pfns[ZONE_NORMAL] = max_low_pfn; > +#ifdef CONFIG_HIGHMEM > + max_zone_pfns[ZONE_HIGHMEM] = max_pfn; > +#endif > +} > > /* > * paging_init() sets up the page tables - in fact we've already done this. > */ > void __init paging_init(void) > { > + unsigned long max_zone_pfns[MAX_NR_ZONES]; > unsigned long long total_ram = memblock_phys_mem_size(); > phys_addr_t top_of_ram = memblock_end_of_DRAM(); > int zone_dma_bits; > @@ -259,15 +269,7 @@ void __init paging_init(void) > > zone_dma_limit = DMA_BIT_MASK(zone_dma_bits); > > -#ifdef CONFIG_ZONE_DMA > - max_zone_pfns[ZONE_DMA] = min(max_low_pfn, > - 1UL << (zone_dma_bits - PAGE_SHIFT)); > -#endif > - max_zone_pfns[ZONE_NORMAL] = max_low_pfn; > -#ifdef CONFIG_HIGHMEM > - max_zone_pfns[ZONE_HIGHMEM] = max_pfn; > -#endif > - > + arch_zone_limits_init(max_zone_pfns); > free_area_init(max_zone_pfns); > > mark_nonram_nosave(); > -- > 2.51.0 _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B0442CF6BEB for ; Wed, 7 Jan 2026 04:58:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:Message-ID:Date :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JwtK0rYpjJ9ZD7MT3gBlAWllLE4bGESbnLvxuT3A9Q8=; b=rfbgPaG++1vB5Q 4JSJ2TVWMTKEzxz/AhyYcsPUq5EaKaGKX7B99e+6bqdtlYlJHU9uyT3ToJwnJ1uAE7Ls877Cxq33w gD8IaaeL/6qKH33oDzx0MNLK0RI/I6WCjrChSLGm9Vu1bjz680PpKGZP8U8MpcNL5rNL51DnFoYT2 JruMz699hTExPITp69dd0IoEpI2Ip8/UVJk2Dcjm2FLAIZ4kA1xklTbEeXDrf68GdV/mjBLgyAGrZ UNDHTW0K1d/yVsCa+T2PvqetSIKJv4O1KCc2rbPu+hPgZ5b3ufLLzpswCSYipC+xILVyvFNt6qeu+ 4wvOf0MsAf9+Ru3kFlFg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vdLcp-0000000EAHd-0lSa; Wed, 07 Jan 2026 04:58:27 +0000 Received: from mail-pj1-x102b.google.com ([2607:f8b0:4864:20::102b]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vdLcl-0000000EAG7-1pQm for linux-snps-arc@lists.infradead.org; Wed, 07 Jan 2026 04:58:25 +0000 Received: by mail-pj1-x102b.google.com with SMTP id 98e67ed59e1d1-34c9edf63a7so1496588a91.1 for ; Tue, 06 Jan 2026 20:58:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767761902; x=1768366702; darn=lists.infradead.org; h=mime-version:references:message-id:date:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=nurUXHNs091EaceKYt0jtxQiBJ2IaAdTDr7CGJ+zWBU=; b=aKqe1+Hs5jYE9MkwLcrTKlJLIw85Lxti/5NndB7CuRNr4YucpZ76yw68w6mVpc7/ZR rAXSpDMV0nsS6Bc49HZ1FPK+ufBBSpn6JNVB7Gc6fiJdsHsOIVIhN3op2toCQXzeBT6F b9GNIV18ETHRWjWwZf7TUH2/JgyOpkM1SVIIov5TiA6qNBoKrVz5U7Rr3AJ0xsgSGcNh A1Q0558A19ZV/0E41l9+J31KFGbkMuTJMI/sfIDVeFZOuDuC/jPbh6DmuzaJ/9XtnYh/ 4AZykFqOMV2OjHOyijx9fATpG2D2edz1BS1NlRoP3L4kcWnFRYR/vJ5vp3izM744JGU6 9kFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767761902; x=1768366702; h=mime-version:references:message-id:date:in-reply-to:subject:cc:to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=nurUXHNs091EaceKYt0jtxQiBJ2IaAdTDr7CGJ+zWBU=; b=q6Jh8wDuj0ElGQfZYgoNIi6j0gBRWhHCzOW6zAO3ENQxZpmfwcYIeMCViVsJsJQhFr 2/e8u0QimhfPLdGk4UZ3Pdsh81/3nHnSXuD9KilC4RgIHT9otOYsQ7hIYE1zyyVhNqLe coLC+EkBgfBpDP1uz6QhMG9nS34gKNFpJ93TdN4jBqabbIkf1TSVidhV47fqPYZfnbrN CHbpDBLl+Hm7/Bad16m1m7iWHVzcj6kd3TLcCfRW2lYI7+ArK9irMQxSmuRPwUdsDG4i ZD3/N/gQuXWZeWQRt73oBdAfUrSVDbtzBpL82vcPJ7HvwPXDRCuT/pWBOpmazevYHJRO A1Ew== X-Forwarded-Encrypted: i=1; AJvYcCXm/EePXLc7bnHIp4D4p3DLhoadNnJ3Cjmc0ob98H45zSG7j0d6g86HZfBNPlgeNcmXBgVFqz+BEVSZ97eMxw==@lists.infradead.org X-Gm-Message-State: AOJu0YzAkuMMLn/RQ10rKpUZQbSjR0v0+TL//lHvR6j/SVx+J6lp1s2T ZtYr3BBb2JKhw1k5ztyCQtBqgWnfn0J9KQKhLZO0c4GJE+RO+LSRzAw6 X-Gm-Gg: AY/fxX50nz/Vp0SEo9G9/k316pohJkRZl3rP5v6QoDqRX3HWVHKyqlG6Bh6q4KcZNCA /LzWst2sf0vMSrg2B8eKdO5+tOVFmutiSsREhLuYD4UfEX2wVsDecSP2B+k4DX9kdLKeHA9IHQx jhsz0/sS6TihosQ4LCq/sM1dOAdZpPBhzDa6TeYfj7iu5KngdSoKBTkNOhf5wFTSvMrGAWXVdWh nWBTORhKmAKsIyesqm6lNmilHGUohr3jEl8xKqdsZsl0M3IZWbQGrZVUGOSnyO7uMjJ/0ygT9lk 6LYxc3xD4iE6jGJNl/tM5kWpI1Zqa20xONoUj1oKuDTKtZHDxXyoxWDX3LD4JA3oqYHfC96LVBU /0HwBrcldc9pWcVEoIAhKt9DIV5+fmqEu5ke0446U4K+7fniazZ1I/9ua8rXocOu+pAcM2bDsyT XcIswcIg== X-Google-Smtp-Source: AGHT+IE3iEJ4twso46GOnqJPDopUox2qFLaKHiDPKI95vlPPxjV/F7mxvaI/CeOE2s8GrRHRScEd6Q== X-Received: by 2002:a17:90b:6c7:b0:335:2eef:4ca8 with SMTP id 98e67ed59e1d1-34f68d3b4a4mr1191743a91.33.1767761901762; Tue, 06 Jan 2026 20:58:21 -0800 (PST) Received: from dw-tp ([49.207.192.172]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-34f5fb75902sm3622895a91.16.2026.01.06.20.58.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Jan 2026 20:58:20 -0800 (PST) From: Ritesh Harjani (IBM) To: Mike Rapoport , Andrew Morton Cc: Alex Shi , Alexander Gordeev , Andreas Larsson , Borislav Petkov , Brian Cain , "Christophe Leroy (CS GROUP)" , Catalin Marinas , "David S. Miller" , Dave Hansen , David Hildenbrand , Dinh Nguyen , Geert Uytterhoeven , Guo Ren , Heiko Carstens , Helge Deller , Huacai Chen , Ingo Molnar , Johannes Berg , John Paul Adrian Glaubitz , Jonathan Corbet , "Liam R. Howlett" , Lorenzo Stoakes , Magnus Lindholm , Matt Turner , Max Filippov , Michael Ellerman , Michal Hocko , Michal Simek , Mike Rapoport , Muchun Song , Oscar Salvador , Palmer Dabbelt , Pratyush Yadav , Richard Weinberger , Russell King , Stafford Horne , Suren Baghdasaryan , Thomas Bogendoerfer , Thomas Gleixner , Vasily Gorbik , Vineet Gupta , Vlastimil Babka , Will Deacon , x86@kernel.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-cxl@vger.kernel.org, linux-doc@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-openrisc@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-um@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, sparclinux@vger.kernel.org Subject: Re: [PATCH v2 14/28] powerpc: introduce arch_zone_limits_init() In-Reply-To: <20260102070005.65328-15-rppt@kernel.org> Date: Wed, 07 Jan 2026 09:57:34 +0530 Message-ID: <87ldia9he1.ritesh.list@gmail.com> References: <20260102070005.65328-1-rppt@kernel.org> <20260102070005.65328-15-rppt@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260106_205823_473970_9CA8BA5F X-CRM114-Status: GOOD ( 18.89 ) X-BeenThere: linux-snps-arc@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux on Synopsys ARC Processors List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-snps-arc" Errors-To: linux-snps-arc-bounces+linux-snps-arc=archiver.kernel.org@lists.infradead.org Mike Rapoport writes: > From: "Mike Rapoport (Microsoft)" > > Move calculations of zone limits to a dedicated arch_zone_limits_init() > function. > > Later MM core will use this function as an architecture specific callback > during nodes and zones initialization and thus there won't be a need to > call free_area_init() from every architecture. > > Signed-off-by: Mike Rapoport (Microsoft) > --- > arch/powerpc/mm/mem.c | 22 ++++++++++++---------- > 1 file changed, 12 insertions(+), 10 deletions(-) > > diff --git a/arch/powerpc/mm/mem.c b/arch/powerpc/mm/mem.c > index 3ddbfdbfa941..32c496bfab4f 100644 > --- a/arch/powerpc/mm/mem.c > +++ b/arch/powerpc/mm/mem.c > @@ -221,13 +221,23 @@ static int __init mark_nonram_nosave(void) > * anyway) will take a first dip into ZONE_NORMAL and get otherwise served by > * ZONE_DMA. > */ > -static unsigned long max_zone_pfns[MAX_NR_ZONES]; > +void __init arch_zone_limits_init(unsigned long *max_zone_pfns) > +{ > +#ifdef CONFIG_ZONE_DMA > + max_zone_pfns[ZONE_DMA] = min(zone_dma_limit, max_low_pfn - 1) + 1; Hi Mike, This doesn't look correct. Isn't the zone_dma_limit value in bytes actually? Shouldn't it be - max_zone_pfns[ZONE_DMA] = min((zone_dma_limit >> PAGE_SHIFT) + 1, max_low_pfn); -ritesh > +#endif > + max_zone_pfns[ZONE_NORMAL] = max_low_pfn; > +#ifdef CONFIG_HIGHMEM > + max_zone_pfns[ZONE_HIGHMEM] = max_pfn; > +#endif > +} > > /* > * paging_init() sets up the page tables - in fact we've already done this. > */ > void __init paging_init(void) > { > + unsigned long max_zone_pfns[MAX_NR_ZONES]; > unsigned long long total_ram = memblock_phys_mem_size(); > phys_addr_t top_of_ram = memblock_end_of_DRAM(); > int zone_dma_bits; > @@ -259,15 +269,7 @@ void __init paging_init(void) > > zone_dma_limit = DMA_BIT_MASK(zone_dma_bits); > > -#ifdef CONFIG_ZONE_DMA > - max_zone_pfns[ZONE_DMA] = min(max_low_pfn, > - 1UL << (zone_dma_bits - PAGE_SHIFT)); > -#endif > - max_zone_pfns[ZONE_NORMAL] = max_low_pfn; > -#ifdef CONFIG_HIGHMEM > - max_zone_pfns[ZONE_HIGHMEM] = max_pfn; > -#endif > - > + arch_zone_limits_init(max_zone_pfns); > free_area_init(max_zone_pfns); > > mark_nonram_nosave(); > -- > 2.51.0 _______________________________________________ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc