From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 29D67CCFA0D for ; Wed, 5 Nov 2025 14:54:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:Message-ID:Date:References:In-Reply-To:To:From:Sender: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=InDE4beOaDxT/mEHe7Ha0gv2i9hwgxrMuSUBTX7dv0k=; b=Z3+XlLHeuEPEmy8KA8tZrIOz80 hQZzHH/AZZnof/ghyc5KH7XIynoTCzOBSlhASMmUjIhwwzVK4we+Se6JGuC8an5e7+S7ZE5B81sQW h4VEGF9u3tucgf4dXl/pVhTTosb2qGogbPnhJN9T1OfQ+taHKk4qVd+SVdYHXdLoj6vw=; Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1vGeuN-0005et-Cf; Wed, 05 Nov 2025 14:54:48 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1vGeuH-0005ei-Lm for linux-f2fs-devel@lists.sourceforge.net; Wed, 05 Nov 2025 14:54:42 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Type:MIME-Version:Message-ID:Date: References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=4WxYZ+JeksWx9qzLRbdr/qx4v36wWsQth6BFNnfgxlQ=; b=dzsS1N6WjEfPNddysgCPBc5P0h 5tHL+FHbxSYNtLsSiNvqQAM69t4OFLIgiC2Rfrp2F4DRVNZNQ98xmxIz/yZ0nqXfTYx9iY0xbv1BC 8FKZAGCBwfwKdE/6hWhQwJ7rMd0Gm2g8oq3yJ2/j8f3r7A3PEHqX1gI7SHYvdDsAFpCc=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To:Subject: Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=4WxYZ+JeksWx9qzLRbdr/qx4v36wWsQth6BFNnfgxlQ=; b=CMnLv+6stbXW65AN/HeWikW+Tx mwdjWr0VU5NKTetXu/fsMR+6jrX/NcF+fSNQf0mfYSMVuToA53txifTdWgn965K7VzyY09eHRvMi/ l7Ejwn89mYJ1C5InJdKCEWplK9v3R6VMvG1enEQycvtpQR7HZgia452hShcxxoQcf6as=; Received: from [193.142.43.55] (helo=galois.linutronix.de) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1vGeuH-0005SO-Dg for linux-f2fs-devel@lists.sourceforge.net; Wed, 05 Nov 2025 14:54:42 +0000 From: John Ogness DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1762354469; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4WxYZ+JeksWx9qzLRbdr/qx4v36wWsQth6BFNnfgxlQ=; b=ixdPaQRVOB+Vf/Rjjt9TIHFHfrqbSTg3oXt1SBrY/0vcLZ3MY87d7ex88vzn9l3lEIuIr4 SYOhn1zLfUUR9JxPwjeVT3ocT2rGfFH9s0+WhzF8+55J3QdyYj0GGo9OxBGtgCLzc3cEB4 j+7huapGfATu6aXcGZx3HvIVIRJd2rx361EYoZ4iWJww4qISDNV+YhQMhfuIfwD9zpD4EU 0vfvDqS4xB2aOQCu29sG8SGr4nzHqkpKmfxGlwBIaWjcQXMCYgdpWNJH4BD4eRd+S5GU80 LcUK6NbiRXQLTibQHLucRQq7kjLOW/8GAhso1ChYyGhbENo+5sYW9hDGQAAu6A== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1762354469; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4WxYZ+JeksWx9qzLRbdr/qx4v36wWsQth6BFNnfgxlQ=; b=2m96Jera/0TPmblmwvx8TPXahXVuSgKJFttdj9F8sJkbbeCoeN5f4LoITxROKlrWQVRSFQ 9nPJhdCcdzIbFODw== To: Petr Mladek , Joanne Koong In-Reply-To: References: <69096836.a70a0220.88fb8.0006.GAE@google.com> Date: Wed, 05 Nov 2025 16:00:28 +0106 Message-ID: <87ldkk34yj.fsf@jogness.linutronix.de> MIME-Version: 1.0 X-Headers-End: 1vGeuH-0005SO-Dg Subject: Re: [f2fs-dev] [syzbot] [iomap?] kernel BUG in folio_end_read (2) X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: brauner@kernel.org, djwong@kernel.org, syzkaller-bugs@googlegroups.com, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, syzbot , jaegeuk@kernel.org, "amurray@thegoodpenguin.co.uk" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 2025-11-04, Petr Mladek wrote: > Adding John into Cc. Thanks. > It rather looks like an internal bug in the printk_ringbuffer code. > And there is only one recent patch: > > https://patch.msgid.link/20250905144152.9137-2-d-tatianin@yandex-team.ru > > The scenario leading to the WARN() is not obvious to me. But the patch > touched this code path. So it is a likely culprit. I have to think > more about it. I have been digging into this all day and I can find no explanation. The patch you refer to brings a minor semantic change: is_blk_wrapped() returns false if begin_lpos and next_lpos are the same, whereas before we would have true. However, these values are not allowed to be the same (except for the data-less special case values). > Anyway, I wonder if the WARNING is reproducible and if it happens even after > reverting the commit 67e1b0052f6bb82be84e3 ("printk_ringbuffer: don't > needlessly wrap data blocks around") Note that a quick search on lore shows another similar report: https://lore.kernel.org/all/69078fb6.050a0220.29fc44.0029.GAE@google.com/ We may want to revert the commit until we can take a closer look at this. I will divert my energies from code-reading to trying to reproduce this. John _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 496CE32145E; Wed, 5 Nov 2025 14:54:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762354472; cv=none; b=j/ulP0OE9pnEs/znBp5+pu6I+lE8FkOXuzRJFt607z1P4iZKpRDoh+npxs5VgJWlAw4ytaQZN+mX2c3DWG7l5nRJ7cMfktS2yQgxpnyMfQnCYnoGAg2yTpADzjfvMdcQlDCgrsC0MvTYhBT4e7zjj4tvf0lNSitzIpVrLeX52PQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762354472; c=relaxed/simple; bh=wg6hvq1fDEKKHo+ksANPIzinuZ9SiV9KbZGzhCFjZa4=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=k9yX+fOEw4IWS7ZB18LhlbUYaFA2CrstnZ1FotGIeSr+OLabvCbXZ3sE1UajNeqF3/JYpEX0xF53S155t27EfUhXiEEjdZcoGJJ5YbmjD/BicNO99fMtv7aJeyuww6Qum4RRdYym0+JWm/sfev5+gJw6/obzYUQ9yyM8kMmdgR8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=ixdPaQRV; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=2m96Jera; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="ixdPaQRV"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="2m96Jera" From: John Ogness DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1762354469; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4WxYZ+JeksWx9qzLRbdr/qx4v36wWsQth6BFNnfgxlQ=; b=ixdPaQRVOB+Vf/Rjjt9TIHFHfrqbSTg3oXt1SBrY/0vcLZ3MY87d7ex88vzn9l3lEIuIr4 SYOhn1zLfUUR9JxPwjeVT3ocT2rGfFH9s0+WhzF8+55J3QdyYj0GGo9OxBGtgCLzc3cEB4 j+7huapGfATu6aXcGZx3HvIVIRJd2rx361EYoZ4iWJww4qISDNV+YhQMhfuIfwD9zpD4EU 0vfvDqS4xB2aOQCu29sG8SGr4nzHqkpKmfxGlwBIaWjcQXMCYgdpWNJH4BD4eRd+S5GU80 LcUK6NbiRXQLTibQHLucRQq7kjLOW/8GAhso1ChYyGhbENo+5sYW9hDGQAAu6A== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1762354469; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4WxYZ+JeksWx9qzLRbdr/qx4v36wWsQth6BFNnfgxlQ=; b=2m96Jera/0TPmblmwvx8TPXahXVuSgKJFttdj9F8sJkbbeCoeN5f4LoITxROKlrWQVRSFQ 9nPJhdCcdzIbFODw== To: Petr Mladek , Joanne Koong Cc: syzbot , "amurray@thegoodpenguin.co.uk" , brauner@kernel.org, chao@kernel.org, djwong@kernel.org, jaegeuk@kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, syzkaller-bugs@googlegroups.com Subject: Re: [syzbot] [iomap?] kernel BUG in folio_end_read (2) In-Reply-To: References: <69096836.a70a0220.88fb8.0006.GAE@google.com> Date: Wed, 05 Nov 2025 16:00:28 +0106 Message-ID: <87ldkk34yj.fsf@jogness.linutronix.de> Precedence: bulk X-Mailing-List: linux-xfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On 2025-11-04, Petr Mladek wrote: > Adding John into Cc. Thanks. > It rather looks like an internal bug in the printk_ringbuffer code. > And there is only one recent patch: > > https://patch.msgid.link/20250905144152.9137-2-d-tatianin@yandex-team.ru > > The scenario leading to the WARN() is not obvious to me. But the patch > touched this code path. So it is a likely culprit. I have to think > more about it. I have been digging into this all day and I can find no explanation. The patch you refer to brings a minor semantic change: is_blk_wrapped() returns false if begin_lpos and next_lpos are the same, whereas before we would have true. However, these values are not allowed to be the same (except for the data-less special case values). > Anyway, I wonder if the WARNING is reproducible and if it happens even after > reverting the commit 67e1b0052f6bb82be84e3 ("printk_ringbuffer: don't > needlessly wrap data blocks around") Note that a quick search on lore shows another similar report: https://lore.kernel.org/all/69078fb6.050a0220.29fc44.0029.GAE@google.com/ We may want to revert the commit until we can take a closer look at this. I will divert my energies from code-reading to trying to reproduce this. John