From: Takashi Iwai <tiwai@suse.de>
To: linux@treblig.org
Cc: perex@perex.cz, tiwai@suse.com, krzysztof.h1@wp.pl,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: msnd: Remove midi code
Date: Mon, 12 May 2025 09:56:14 +0200 [thread overview]
Message-ID: <87ldr2uush.wl-tiwai@suse.de> (raw)
In-Reply-To: <20250511172957.1001583-1-linux@treblig.org>
On Sun, 11 May 2025 19:29:57 +0200,
linux@treblig.org wrote:
>
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
>
> Nothing calls snd_msndmidi_new()
> thus nothing sets chip->msndmidi_mpu
> The call to snd_msndmidi_input_read is gated on that being set,
> so snd_msndmidi_input_read() won't be called either.
>
> This is probably a missing call to snd_msndmidi_new(), but since
> this is ancient code, it's probably best to remove it (especially
> since I don't have the hardware to test it).
>
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
Applied now. Thanks.
Takashi
next prev parent reply other threads:[~2025-05-12 7:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-11 17:29 [PATCH] ALSA: msnd: Remove midi code linux
2025-05-12 7:56 ` Takashi Iwai [this message]
2025-05-12 11:18 ` Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ldr2uush.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=krzysztof.h1@wp.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=linux@treblig.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.