Re: [PATCH 4/5] target/rx: Load reset vector from memory after first run

[Keith Packard via <qemu-devel@nongnu.org>]

[-- Attachment #1: Type: text/plain, Size: 965 bytes --]


> So I'm OK with this patch doing this the way it does,
> except that I have one question: what's that
> process_queued_cpu_work() call doing? We don't need
> that on the Arm equivalent...

Yup, I needed that because I was running this bit at cpu_reset_hold
time, not waiting until after cpu reset was finished. At cpu_reset_hold
time, the re-initialization of memory_dispatch hadn't been executed yet,
so attempts to resolve addresses crashed unless I synchronously flushed
the work queue where the call to tcg_commit_cpu was pending.

All fixed now that I'm setting the pc after the call to cpu_reset has
completed.

> Also, if() statements always have braces in QEMU, even
> if the body of the if is a single statement. But since
> if you don't set env->pc it is zero anyway, you don't
> need the if() at all I think and can directly set
> env->pc unconditionally.

Thanks for the formatting advice; I'll get it cleaned up.

-- 
-keith

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]