From: Kalle Valo <kvalo@kernel.org>
To: Lorenzo Bianconi <lorenzo@kernel.org>
Cc: Alper Nebi Yasak <alpernebiyasak@gmail.com>,
linux-mediatek@lists.infradead.org,
linux-wireless@vger.kernel.org, Felix Fietkau <nbd@nbd.name>,
Ryder Lee <ryder.lee@mediatek.com>,
Shayne Chen <shayne.chen@mediatek.com>,
Sean Wang <sean.wang@mediatek.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Ming Yen Hsieh <mingyen.hsieh@mediatek.com>,
Deren Wu <deren.wu@mediatek.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, Ma Ke <make24@iscas.ac.cn>,
regressions@lists.linux.dev
Subject: Re: BUG and WARNINGs from mt7921s on next-20240916
Date: Tue, 17 Sep 2024 09:17:20 +0300 [thread overview]
Message-ID: <87ldzqdcsv.fsf@kernel.org> (raw)
In-Reply-To: <ZujCwvd4XiwljDyv@lore-desk> (Lorenzo Bianconi's message of "Tue, 17 Sep 2024 01:44:02 +0200")
Lorenzo Bianconi <lorenzo@kernel.org> writes:
>> Hi,
>>
>> I ran into some bug messages while testing linux-next on a MT8186
>> Magneton Chromebook (mt8186-corsola-magneton-sku393218). It boots
>> to the OS, but at least Wi-Fi and Bluetooth are unavailable.
>>
>> As a start, I tried reverting commit abbd838c579e ("Merge tag
>> 'mt76-for-kvalo-2024-09-06' of https://github.com/nbd168/wireless")
>> and it works fine after that. Didn't have time to do a full bisect,
>> but will try if nobody has any immediate opinions.
>>
>> There are a few traces, here's some select lines to catch your attention,
>> not sure how informational they are:
>>
>> [ 16.040525] kernel BUG at net/core/skbuff.c:2268!
>> [ 16.040531] Internal error: Oops - BUG: 00000000f2000800 [#1] SMP
>> [ 16.040803] CPU: 3 UID: 0 PID: 526 Comm: mt76-sdio-txrx Not tainted
>> 6.11.0-next-20240916-deb-00002-g7b544e01c649 #1
>> [ 16.040897] Call trace:
>> [ 16.040899] pskb_expand_head+0x2b0/0x3c0
>> [ 16.040905] mt76s_tx_run_queue+0x274/0x410 [mt76_sdio]
>> [ 16.040909] mt76s_txrx_worker+0xe4/0xac8 [mt76_sdio]
>> [ 16.040914] mt7921s_txrx_worker+0x98/0x1e0 [mt7921s]
>> [ 16.040924] __mt76_worker_fn+0x80/0x128 [mt76]
>> [ 16.040934] kthread+0xe8/0xf8
>> [ 16.040940] ret_from_fork+0x10/0x20
>
> Hi,
>
> I guess this issue has been introduced by the following commit:
>
> commit 3688c18b65aeb2a1f2fde108400afbab129a8cc1
> Author: Felix Fietkau <nbd@nbd.name>
> Date: Tue Aug 27 11:30:01 2024 +0200
>
> wifi: mt76: mt7915: retry mcu messages
>
> In some cases MCU messages can get lost. Instead of failing completely,
> attempt to recover by re-sending them.
>
> Link: https://patch.msgid.link/20240827093011.18621-14-nbd@nbd.name
> Signed-off-by: Felix Fietkau <nbd@nbd.name>
>
>
> In particular, skb_get() in mt76_mcu_skb_send_and_get_msg() is bumping skb users
> refcount (making the skb shared) and pskb_expand_head() (run by __skb_grow() in
> mt76s_tx_run_queue()) does not like shared skbs.
>
> @Felix: any input on it?
Adding regressions list to Cc.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2024-09-17 6:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-16 19:33 BUG and WARNINGs from mt7921s on next-20240916 Alper Nebi Yasak
2024-09-16 23:44 ` Lorenzo Bianconi
2024-09-17 6:17 ` Kalle Valo [this message]
2024-09-17 9:05 ` Alper Nebi Yasak
2024-09-17 9:15 ` Felix Fietkau
2024-09-17 10:08 ` Alper Nebi Yasak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ldzqdcsv.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=alpernebiyasak@gmail.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=deren.wu@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo@kernel.org \
--cc=make24@iscas.ac.cn \
--cc=matthias.bgg@gmail.com \
--cc=mingyen.hsieh@mediatek.com \
--cc=nbd@nbd.name \
--cc=regressions@lists.linux.dev \
--cc=ryder.lee@mediatek.com \
--cc=sean.wang@mediatek.com \
--cc=shayne.chen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.