From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8ACE8C02181 for ; Sat, 14 Sep 2024 07:26:12 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1spN9o-00033h-Ea; Sat, 14 Sep 2024 03:25:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1spN9n-00033E-8b for qemu-devel@nongnu.org; Sat, 14 Sep 2024 03:25:23 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1spN9l-00082Z-Ro for qemu-devel@nongnu.org; Sat, 14 Sep 2024 03:25:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1726298720; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mPBtZF6hpBoTWQZSLizhPA9ikBJuY1EGH2kygSVkbZU=; b=hl/t80PcaOdnc04WIX7tJwq9ndBqyJypZmdxLkjsu1HKe42ZjSOLjypubpVUT8saLiCi9i A7jw8A8822pmBEX7IHNtUZSl3B9tiVDZgJMTjWdIFiKY1qfpwy1zHF0LXhtKuIf7dzhyTp yXvwXiusLtxqNINFfUqdfBkLHGBR348= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-195-DtBkEoSHNva0Rx_CG1Qs9Q-1; Sat, 14 Sep 2024 03:25:16 -0400 X-MC-Unique: DtBkEoSHNva0Rx_CG1Qs9Q-1 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id EF68B1956083; Sat, 14 Sep 2024 07:25:14 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.192.112]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 726D63001D13; Sat, 14 Sep 2024 07:25:13 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 3B6D321E6A28; Sat, 14 Sep 2024 09:25:11 +0200 (CEST) From: Markus Armbruster To: Daniil Tatianin Cc: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , Paolo Bonzini , Eric Blake , qemu-devel@nongnu.org, devel@lists.libvirt.org, Peter Krempa , Michal Privoznik , Vladimir Sementsov-Ogievskiy Subject: Re: [PATCH v2] chardev: introduce 'reconnect-ms' and deprecate 'reconnect' In-Reply-To: <20240913094604.269135-1-d-tatianin@yandex-team.ru> (Daniil Tatianin's message of "Fri, 13 Sep 2024 12:46:04 +0300") References: <20240913094604.269135-1-d-tatianin@yandex-team.ru> Date: Sat, 14 Sep 2024 09:25:11 +0200 Message-ID: <87ldzuvgrs.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass client-ip=170.10.129.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.147, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Daniil Tatianin writes: > The 'reconnect' option only allows to specify the time in seconds, > which is way too long for certain workflows. > > We have a lightweight disk backend server, which takes about 20ms to > live update, but due to this limitation in QEMU, previously the guest > disk controller would hang for one second because it would take this > long for QEMU to reinitialize the socket connection. > > Introduce a new option called 'reconnect-ms', which is the same as > 'reconnect', except the value is treated as milliseconds. These are > mutually exclusive and specifying both results in an error. > > 'reconnect' is also deprecated by this commit to make it possible to > remove it in the future as to not keep two options that control the > same thing. > > Reviewed-by: Vladimir Sementsov-Ogievskiy > Acked-by: Peter Krempa > Signed-off-by: Daniil Tatianin Tested-by: Markus Armbruster Acked-by: Markus Armbruster