From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B9FEECD342E for ; Tue, 3 Sep 2024 13:04:27 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1slTC9-0000ti-Pl; Tue, 03 Sep 2024 09:03:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1slTC7-0000sh-DS for qemu-devel@nongnu.org; Tue, 03 Sep 2024 09:03:39 -0400 Received: from smtp-out2.suse.de ([2a07:de40:b251:101:10:150:64:2]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1slTC5-0001lJ-OL for qemu-devel@nongnu.org; Tue, 03 Sep 2024 09:03:39 -0400 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 34C4B1F365; Tue, 3 Sep 2024 13:03:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1725368614; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=UcPVLxLaPwBS8onsjxlDBpDptegjtODrFEqt/steavI=; b=NwbjYpM9tdqxAEvw1LLMXQ1QWzeTL7SoF9DVIfDhXwJbm+kXBYU2Ri/dKSlDiSKXMRX02U Di7w6O5NZRzg8JMY+S5gwViepD+UT10E50kmPKQBLB6Ble/Nqk/rxJL9lSBRvZKUsMwzi0 IFJY5xhZgGrFVdx0V8+uZibqrpIIpFU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1725368614; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=UcPVLxLaPwBS8onsjxlDBpDptegjtODrFEqt/steavI=; b=2b+RJHfTFOOfY+V5Yb/DQxyrgctbSkzwJ7dYeMR0dMEPVn5jdH86AaUil4Brzk2iEcaWDp 19JeauHopdzfJLAA== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=NwbjYpM9; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=2b+RJHfT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1725368614; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=UcPVLxLaPwBS8onsjxlDBpDptegjtODrFEqt/steavI=; b=NwbjYpM9tdqxAEvw1LLMXQ1QWzeTL7SoF9DVIfDhXwJbm+kXBYU2Ri/dKSlDiSKXMRX02U Di7w6O5NZRzg8JMY+S5gwViepD+UT10E50kmPKQBLB6Ble/Nqk/rxJL9lSBRvZKUsMwzi0 IFJY5xhZgGrFVdx0V8+uZibqrpIIpFU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1725368614; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=UcPVLxLaPwBS8onsjxlDBpDptegjtODrFEqt/steavI=; b=2b+RJHfTFOOfY+V5Yb/DQxyrgctbSkzwJ7dYeMR0dMEPVn5jdH86AaUil4Brzk2iEcaWDp 19JeauHopdzfJLAA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id B362913A80; Tue, 3 Sep 2024 13:03:33 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id Ra8wHiUJ12boPwAAD6G6ig (envelope-from ); Tue, 03 Sep 2024 13:03:33 +0000 From: Fabiano Rosas To: Thomas Huth , Peter Xu , qemu-devel@nongnu.org Subject: Re: [PATCH] tests/qtest/migration: Add a check for the availability of the "pc" machine In-Reply-To: <20240903114726.199881-1-thuth@redhat.com> References: <20240903114726.199881-1-thuth@redhat.com> Date: Tue, 03 Sep 2024 10:03:30 -0300 Message-ID: <87le08nb31.fsf@suse.de> MIME-Version: 1.0 Content-Type: text/plain X-Rspamd-Queue-Id: 34C4B1F365 X-Spamd-Result: default: False [-6.51 / 50.00]; BAYES_HAM(-3.00)[99.99%]; DWL_DNSWL_MED(-2.00)[suse.de:dkim]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_HAS_DN(0.00)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; ARC_NA(0.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_TLS_ALL(0.00)[]; DKIM_TRACE(0.00)[suse.de:+]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; MISSING_XM_UA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:email,suse.de:dkim,suse.de:mid] X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Action: no action Received-SPF: pass client-ip=2a07:de40:b251:101:10:150:64:2; envelope-from=farosas@suse.de; helo=smtp-out2.suse.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Thomas Huth writes: > The test_vcpu_dirty_limit is the only test that does not check for the > availability of the machine before starting the test, so it fails when > QEMU has been configured with --without-default-devices. Add a check for > the "pc" machine type to fix it. > > Signed-off-by: Thomas Huth > --- > tests/qtest/migration-test.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c > index 6c06100d91..8fee18dfbe 100644 > --- a/tests/qtest/migration-test.c > +++ b/tests/qtest/migration-test.c > @@ -4026,8 +4026,10 @@ int main(int argc, char **argv) > if (g_str_equal(arch, "x86_64") && has_kvm && kvm_dirty_ring_supported()) { > migration_test_add("/migration/dirty_ring", > test_precopy_unix_dirty_ring); > - migration_test_add("/migration/vcpu_dirty_limit", > - test_vcpu_dirty_limit); > + if (qtest_has_machine("pc")) { > + migration_test_add("/migration/vcpu_dirty_limit", > + test_vcpu_dirty_limit); > + } > } > > ret = g_test_run(); Reviewed-by: Fabiano Rosas