From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a17:505:3f8c:b0:1be9:327d:8ee3 with SMTP id bm12csp1358851njb; Fri, 2 Aug 2024 07:27:56 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXhLA8OqjEwKnjvgLq4wLHivnHJ36uYRhH8YYe5BXm+jn8drx9t/iKzQtG6+66UldFbCOHaVYv1jQyJ8LT+ne76XuRPI1wu X-Google-Smtp-Source: AGHT+IFrvqiGdUA2RXGKyOhPL4dRCHZA4gXOJ3jB3iUV50bie5hBWucHVM+IeSDXFFou2Yv0z2gr X-Received: by 2002:a05:6a20:7f91:b0:1c4:aa58:bdbd with SMTP id adf61e73a8af0-1c699585c35mr4541927637.25.1722608876278; Fri, 02 Aug 2024 07:27:56 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1722608876; cv=pass; d=google.com; s=arc-20160816; b=wgJKNlVLheawIKekK5H49VscjEB9mc+G5FAUaOrZzwqTp9+1IPaBuyDksycDL5ilKH /Xz9cQS67J0H0OiXYm2JQ5sck40lWLIZFD+P47UCsjRp1vr3kRdtU8DHNpOiavwtq6tR BsSMjhSUk2csvs5gdLenj2YjH7pJocxQq/9KbZN/waoeA5TauEklZuXRd/vtIhycXUrd emnwMmAsTV8SIiJniZ7+xGEYEa0v/jp3s5uoSkNH5nRcZKIlLM36vwbz6q5MjZ59ttb5 VrSa8UCptpjpGqU4R0CfkH+5yKGWn/SVHRiZC57XE9om38CFVB5kVpKT+8q42hmoVIaZ Bj3A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:dkim-signature; bh=0AF836Ndnqh+hwBkZ5YXfF8VJZkH/V2VUoPsaRxoRbo=; fh=UgDMdQufQceGHSQ5mvYK+gXMuNACbgO7xw5RplzcQ2g=; b=Mnq8iNGZxzksKx4ogG0w7a1obsErROXXvw67uLzjbO9JyW7H8a/7a0JTOncmunHMWG GSveNGa8JPybxlSSeFAA3sVjJB8gX2RHR00sQ/Xe2qr+eGb7d5ouIktfd8C+oT+AZspH SsUnld0jml0O8RcyFGWI98R2zNwQTqj+KrmABlaErpjw40kmoqazZTsTrm2+R9Nu+zVu 1eyDjcEx6NP4ULbtPeiz8PcR8zXhhmwoTWPFvZa17AD51cATGmeKrOHMXqQuB7iffvt0 sU8boFTDQGoyxDlRAtNkObGjAgNmBoylq64aKXOnETIVPjvLtoN3jTs7taC6GCItEvLn DdyQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=LNrTxs4s; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of kvm+bounces-23047-alex.bennee=linaro.org@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="kvm+bounces-23047-alex.bennee=linaro.org@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id 41be03b00d2f7-7b7654c5d1asi2032136a12.438.2024.08.02.07.27.56 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Aug 2024 07:27:56 -0700 (PDT) Received-SPF: pass (google.com: domain of kvm+bounces-23047-alex.bennee=linaro.org@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=LNrTxs4s; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of kvm+bounces-23047-alex.bennee=linaro.org@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="kvm+bounces-23047-alex.bennee=linaro.org@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id C51EA281FDA for ; Fri, 2 Aug 2024 14:27:55 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 491741E4F0F; Fri, 2 Aug 2024 14:27:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="LNrTxs4s" Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6144118B48C for ; Fri, 2 Aug 2024 14:27:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722608871; cv=none; b=cFDj0gqLmh7xX20cPfTIocXWxD11cyGr8wemo4nt0LQskV4e4QkS7/sUxUMndi1k9ecwek8fjwVl0f9/BWxpr4jldFT2Ta/ld+I1CiWdu9Mmoa2rBy5sPcxRxxry/X/4OcI5jqbrwqUTWa+1nYUtv98Ubo6+cqHvHdrtCmDTMVc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722608871; c=relaxed/simple; bh=X4jmHBSxvxql7GSDWaFyUViEdiHMRKgMs/wop+HFBAk=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=mgLRWIXgllg+XcJPH0dlANdWfrAxJnZY44Ph+pWJrC926qtAe4JLwDUMaaskoVI1ebFswe4pt2wyrJ7RpMsGVz08zYb94mHXvwhFPPfUdNCkbmhwMzZARiIPqCCFNlef5wAPHcrLqS3Gu8KLQg9+dCIlX6pcA9i4L9CAOuDSXZE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=LNrTxs4s; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1722608868; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0AF836Ndnqh+hwBkZ5YXfF8VJZkH/V2VUoPsaRxoRbo=; b=LNrTxs4sGNC5O698Ma5pmjalcVXD094p/HYvlYeTMhwB7BI/g9qcNMxcjSebmkYVbbJpmR LEadjh6WEYbBHb4+GqOAMier8xrOZ53QvFueCfz26ME7aCmfZm5hkM7ABUdSjWOx/4TlLb H8yRCVrG0ARKHVRRvZQNrV1vcNxQtW4= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-447-XWO4I8cYMCuIDar7bdZhBw-1; Fri, 02 Aug 2024 10:27:43 -0400 X-MC-Unique: XWO4I8cYMCuIDar7bdZhBw-1 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 28AEC1955F3B; Fri, 2 Aug 2024 14:27:30 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.192.65]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E9187300018D; Fri, 2 Aug 2024 14:27:25 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id B5E1B21E668F; Fri, 2 Aug 2024 16:27:23 +0200 (CEST) From: Markus Armbruster To: Daniel P. =?utf-8?Q?Berrang=C3=A9?= Cc: qemu-devel@nongnu.org, alex.williamson@redhat.com, andrew@codeconstruct.com.au, andrew@daynix.com, arei.gonglei@huawei.com, berto@igalia.com, borntraeger@linux.ibm.com, clg@kaod.org, david@redhat.com, den@openvz.org, eblake@redhat.com, eduardo@habkost.net, farman@linux.ibm.com, farosas@suse.de, hreitz@redhat.com, idryomov@gmail.com, iii@linux.ibm.com, jamin_lin@aspeedtech.com, jasowang@redhat.com, joel@jms.id.au, jsnow@redhat.com, kwolf@redhat.com, leetroy@gmail.com, marcandre.lureau@redhat.com, marcel.apfelbaum@gmail.com, michael.roth@amd.com, mst@redhat.com, mtosatti@redhat.com, nsg@linux.ibm.com, pasic@linux.ibm.com, pbonzini@redhat.com, peter.maydell@linaro.org, peterx@redhat.com, philmd@linaro.org, pizhenwei@bytedance.com, pl@dlhnet.de, richard.henderson@linaro.org, stefanha@redhat.com, steven_lee@aspeedtech.com, thuth@redhat.com, vsementsov@yandex-team.ru, wangyanan55@huawei.com, yuri.benditovich@daynix.com, zhao1.liu@intel.com, qemu-block@nongnu.org, qemu-arm@nongnu.org, qemu-s390x@nongnu.org, kvm@vger.kernel.org Subject: Re: [PATCH 11/18] qapi/crypto: Rename QCryptoHashAlgorithm to *Algo, and drop prefix In-Reply-To: ("Daniel P. =?utf-8?Q?Berrang?= =?utf-8?Q?=C3=A9=22's?= message of "Wed, 31 Jul 2024 10:46:52 +0100") References: <20240730081032.1246748-1-armbru@redhat.com> <20240730081032.1246748-12-armbru@redhat.com> <8734nrgj5i.fsf@pond.sub.org> Date: Fri, 02 Aug 2024 16:27:23 +0200 Message-ID: <87le1fxano.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-TUID: pjPYs4lHyejB Daniel P. Berrang=C3=A9 writes: > On Tue, Jul 30, 2024 at 02:26:49PM +0200, Markus Armbruster wrote: >> Daniel P. Berrang=C3=A9 writes: >>=20 >> > On Tue, Jul 30, 2024 at 10:10:25AM +0200, Markus Armbruster wrote: >> >> QAPI's 'prefix' feature can make the connection between enumeration >> >> type and its constants less than obvious. It's best used with >> >> restraint. >> >>=20 >> >> QCryptoHashAlgorithm has a 'prefix' that overrides the generated >> >> enumeration constants' prefix to QCRYPTO_HASH_ALG. >> >>=20 >> >> We could simply drop 'prefix', but then the prefix becomes >> >> QCRYPTO_HASH_ALGORITHM, which is rather long. >> >>=20 >> >> We could additionally rename the type to QCryptoHashAlg, but I think >> >> the abbreviation "alg" is less than clear. >> > >> > I would have gone with this, but it is a bit of a bike shed colouring >> > debate so I'm not fussed >>=20 >> Either solution seems okay, so I went with my personal preference. Do >> feel free to state yours and ask me to respin! > > After reviewing the patches that follow, I'd observe that picking > Algo has made the following patches much larger than if it had > stuck with Alg. Basically changing both the types & constants, > instead of only having to change the types.=20 Yes. Worth the more obvious names to me, but again, feel free to ask me to respin for less churn.