From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Bennée Date: Thu, 01 Aug 2024 10:53:39 +0100 Subject: [PATCH v12 24/84] KVM: Use plain "struct page" pointer instead of single-entry array In-Reply-To: <20240726235234.228822-25-seanjc@google.com> (Sean Christopherson's message of "Fri, 26 Jul 2024 16:51:33 -0700") References: <20240726235234.228822-1-seanjc@google.com> <20240726235234.228822-25-seanjc@google.com> Message-ID: <87le1gefh8.fsf@draig.linaro.org> List-Id: To: kvm-riscv@lists.infradead.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sean Christopherson writes: > Use a single pointer instead of a single-entry array for the struct page > pointer in hva_to_pfn_fast(). Using an array makes the code unnecessarily > annoying to read and update. > > No functional change intended. > > Signed-off-by: Sean Christopherson Reviewed-by: Alex Benn?e -- Alex Benn?e Virtualisation Tech Lead @ Linaro From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f43.google.com (mail-ed1-f43.google.com [209.85.208.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 17CE616F267 for ; Thu, 1 Aug 2024 09:53:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722506031; cv=none; b=Rk86cKGrxwlowHo9OLeVIsraOdZBlqCz21TqAcfN/PQjXhQnKdJUkmlZ/BmlDB5sQ069I7vE5H5jCdCEA4vZPvg5xX7o1P4t9dECvqsv46RGB/gZN+Kd7BWX2Vw7q0CpBjU/XrUK+uxo0wGAKrV7wcTyLoVtYarVJugZsYCA4uk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722506031; c=relaxed/simple; bh=RZpvv9TExV/YqUUjMHmoW7U1MADjmJXiZRuzMf5dgoY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=EMkSRGi2uKC7+K7Rte30hxiRpafQd+7aqmrjIDM/zSVE3CTLkL7U0kz9uAFV8HeajtK14Vb3Ob/6kWfIgdsYFzbkr948lePeWsS2BKHh6nZia6h/koW/xXS2ov8jvx9/oZx+3avsjZnRSAFv4vnE+Ah0+oJWbx+ITREDEutRrAY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=JxlpAED4; arc=none smtp.client-ip=209.85.208.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="JxlpAED4" Received: by mail-ed1-f43.google.com with SMTP id 4fb4d7f45d1cf-5a79df5af51so3486278a12.0 for ; Thu, 01 Aug 2024 02:53:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1722506028; x=1723110828; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=8MGDW2w0EUrwnI4S//nT3S+vOipXyZxOwDlAdIY1JMk=; b=JxlpAED4oqR2gRgi4lAt9v4jqFsHhstbX3fk6rH1KuHqH8KTim9/ZwRy6y7IAJ1ilo SL9Wnl7vQ1Q+N6LAldn32HZB4Bw+y+T/ISNaK/CbdYjFmA2aEoivf+E3Acf2dBu3QF8+ fqqmyed1zUuKXvF5ah7+uVjW5muhrT2C23lMeXvYEmD/9hQUl62BSdjBw0NHd3N/6sb7 X9Z+qv5kXP4n1Ops4Ok/cuFdVoUAMSx8FjtHjLu5bNgyYzxGKCpnMsDHWduI7uv4eaNm Le+01isRFuWZSzzwEP2Jigx9xV+y0QJvy9OQgoMFnHM2qThXYejryEVOIqh8Sy8phFxo 3Kyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722506028; x=1723110828; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8MGDW2w0EUrwnI4S//nT3S+vOipXyZxOwDlAdIY1JMk=; b=D2+/0pO0zoFWh/iR82GUvTpAC/HkbB5S/jJ5tH++Y6NcFaq9sDPM6vTjUaSHsJNYY3 gSlsdsvtG1AcqQ1kZrXYOJ+/uG/rR8iWP2xQFKtcFJdB9n1E87DlvfSTzYReP8ij7a+X UBPSWheCn7JEJBZSlL+WttfYPiS7RKSZkyGAqymLsbfoBfz6VTLINnUonCPE2riJZMlw zXCcyWi2jRbQlSc/IcIOuhfsgCfcilG6bDmdfQh3O2HJLDf2hd4kjpXqQ7CQdsmugzwY Cd4mNCjjBKq+cxS+1M6d4NBJTAg/R+rZyLcN4/QNOwGFqOm/iYgRYSFwnXNIbqS6wJIM 1n1A== X-Forwarded-Encrypted: i=1; AJvYcCU6D/0Hh4c9ihNeOsA2JCTFu1H/s1LLVp11ekB+siO+Hd/aYLHmbQMxqtq4BfIJiO2Szge0QamKiTCPkOS6uzHJz9yzmEDZ X-Gm-Message-State: AOJu0YyyYwrqM3NrNLQtb+oAbXO0xh+mHtumA3PDVCgfyKVNp4lr0W7S 3MM5PqcOah+1+PU914mcoBVtzi71bYQckMqFoki6haYTiQhHKrR/BJqXSkG/MAg= X-Google-Smtp-Source: AGHT+IHNrw29WKyolinu6cyXHFfq+0WsM6WXcBxZ1/oFvQaGEtI1aOWo6VY84S/JlZwJgkWdM0qlVw== X-Received: by 2002:a05:6402:440d:b0:57d:5442:a709 with SMTP id 4fb4d7f45d1cf-5b778dc53f8mr879162a12.0.1722506028149; Thu, 01 Aug 2024 02:53:48 -0700 (PDT) Received: from draig.lan ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5b5257f39adsm2866327a12.96.2024.08.01.02.53.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Aug 2024 02:53:41 -0700 (PDT) Received: from draig (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id CC0595F80C; Thu, 1 Aug 2024 10:53:39 +0100 (BST) From: =?utf-8?Q?Alex_Benn=C3=A9e?= To: Sean Christopherson Cc: Paolo Bonzini , Marc Zyngier , Oliver Upton , Tianrui Zhao , Bibo Mao , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, David Matlack , David Stevens Subject: Re: [PATCH v12 24/84] KVM: Use plain "struct page" pointer instead of single-entry array In-Reply-To: <20240726235234.228822-25-seanjc@google.com> (Sean Christopherson's message of "Fri, 26 Jul 2024 16:51:33 -0700") References: <20240726235234.228822-1-seanjc@google.com> <20240726235234.228822-25-seanjc@google.com> Date: Thu, 01 Aug 2024 10:53:39 +0100 Message-ID: <87le1gefh8.fsf@draig.linaro.org> Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Sean Christopherson writes: > Use a single pointer instead of a single-entry array for the struct page > pointer in hva_to_pfn_fast(). Using an array makes the code unnecessarily > annoying to read and update. > > No functional change intended. > > Signed-off-by: Sean Christopherson Reviewed-by: Alex Benn=C3=A9e --=20 Alex Benn=C3=A9e Virtualisation Tech Lead @ Linaro From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ED7CFC3DA64 for ; Thu, 1 Aug 2024 09:54:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Vjx8B6L/+xXHhlbkbNvPKLHzxHezPvvMEbGbb53CmBg=; b=w5v/FAAAUUx40E i+sqIuwj7B2MJiV+QqPZUGonuns7HqrX0ARU8mJBnVx3XC3JDwXwUpG1A8EgDjZfu8IFugtN3dJLQ BUiaytI/sXirPxhq6ma5DZZAIEPqUm2A07v9vCS9F1B9yRh1FpxYpBditOpkwc7oODgaV11obm4sr P5qMcQci7pr+pAfUf6LmY+3POyUTDpjV+21e9XfHC44CxdCYhU+iRBnLpKxpokPMCMpqMapjxq9S2 wuARyFo9kELTa8apNnQVWd6vrDXgn3hrmSX6JT2j9IgYQN61Rz13J/g5EQPkHtiFCFTXf/Ud+7+9+ hCL3pVeXK6/gZZZQ5dhQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sZSVo-00000004f4s-3Wwc; Thu, 01 Aug 2024 09:54:20 +0000 Received: from mail-ed1-x532.google.com ([2a00:1450:4864:20::532]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sZSVK-00000004exg-2a8P for linux-riscv@lists.infradead.org; Thu, 01 Aug 2024 09:53:52 +0000 Received: by mail-ed1-x532.google.com with SMTP id 4fb4d7f45d1cf-595856e2336so3153148a12.1 for ; Thu, 01 Aug 2024 02:53:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1722506028; x=1723110828; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=8MGDW2w0EUrwnI4S//nT3S+vOipXyZxOwDlAdIY1JMk=; b=lo/0HKg90P3nYPiJcV1ofYUB1dJDKuttDuy2/3TM1uCjmWxvYH4B5IkcXa8/pdkfV/ ibNbfFtVxkSrGNUl2otlYwrpv7sgZJ33fyz0mjdh1zzHhTYe+SwYbQXX36WKT9llPII7 guyKHoIg1k7c4cCI7A4F781lAiFwC98eLrdXcBCYpM5WPLHTMkUAf0EkEJNBbgoWq7TN UzzrMSpackHgWSpHSTWkt4T3/Vf/TNbMJpFwLhv11qNlJRvo2suyWYx2YRU3I0UmPj2B 3UhjAXUTtTaTi9FSTBBUL8h0/bQUzFoovLkW3t+KoU8gO8QNc6P0yu5++APO871lZ2+9 zaHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722506028; x=1723110828; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8MGDW2w0EUrwnI4S//nT3S+vOipXyZxOwDlAdIY1JMk=; b=WOezX24JSxySY6zzFX+op25rbidalsfAKn/DWrZzhxQFv2hqdroudXm/CHMMejPR/B TCjMbrWl6h0APxfvwbPmfy3Uc4uEy0DdQM9dhZtYuvXkez5JBLqlw6GJiK7CBipT2/0f Xq+W1if8+LlKVJMzEU1c7CoaotoxTyG8xTU9q0PCFq/+JJ1wltGe2mVrPbT7n2lFVoiI L9bwg4UvACgsw9Ng2oozG901LqsFejAX/Yj5qxkbdzGDliNAja7eV1AuDKOfUCJmzHQ0 xqBWFyR8okAhxmoO+Ta3kLUmjKIr1Wz0ilWeoGqi5L0jG/E8+c0FwKeNBRCgMyyAI9wb u5ww== X-Forwarded-Encrypted: i=1; AJvYcCVek8QPvi/9hLNmher3wW/perEOpHppqLx9MJ3N3dOgPj8jMBb/5OKnuLOQYjfPbGe8YxTyNUZkwVtmyw/KRNafKm7co3dzq76Wsd262GMM X-Gm-Message-State: AOJu0Yz4aRWic5Jwh2Fn11JfXtY1CUHzV2/DEjzh4i9/tCLzcB7uHRi8 5jg/hCz05I/RRUEddPa+lX0cIr7klXY6cCFr7s2jey0+IIuNY1hXCRBYo5gEg3U= X-Google-Smtp-Source: AGHT+IHNrw29WKyolinu6cyXHFfq+0WsM6WXcBxZ1/oFvQaGEtI1aOWo6VY84S/JlZwJgkWdM0qlVw== X-Received: by 2002:a05:6402:440d:b0:57d:5442:a709 with SMTP id 4fb4d7f45d1cf-5b778dc53f8mr879162a12.0.1722506028149; Thu, 01 Aug 2024 02:53:48 -0700 (PDT) Received: from draig.lan ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5b5257f39adsm2866327a12.96.2024.08.01.02.53.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Aug 2024 02:53:41 -0700 (PDT) Received: from draig (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id CC0595F80C; Thu, 1 Aug 2024 10:53:39 +0100 (BST) From: =?utf-8?Q?Alex_Benn=C3=A9e?= To: Sean Christopherson Cc: Paolo Bonzini , Marc Zyngier , Oliver Upton , Tianrui Zhao , Bibo Mao , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, David Matlack , David Stevens Subject: Re: [PATCH v12 24/84] KVM: Use plain "struct page" pointer instead of single-entry array In-Reply-To: <20240726235234.228822-25-seanjc@google.com> (Sean Christopherson's message of "Fri, 26 Jul 2024 16:51:33 -0700") References: <20240726235234.228822-1-seanjc@google.com> <20240726235234.228822-25-seanjc@google.com> Date: Thu, 01 Aug 2024 10:53:39 +0100 Message-ID: <87le1gefh8.fsf@draig.linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240801_025350_662431_E0296F59 X-CRM114-Status: UNSURE ( 7.44 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org U2VhbiBDaHJpc3RvcGhlcnNvbiA8c2VhbmpjQGdvb2dsZS5jb20+IHdyaXRlczoKCj4gVXNlIGEg c2luZ2xlIHBvaW50ZXIgaW5zdGVhZCBvZiBhIHNpbmdsZS1lbnRyeSBhcnJheSBmb3IgdGhlIHN0 cnVjdCBwYWdlCj4gcG9pbnRlciBpbiBodmFfdG9fcGZuX2Zhc3QoKS4gIFVzaW5nIGFuIGFycmF5 IG1ha2VzIHRoZSBjb2RlIHVubmVjZXNzYXJpbHkKPiBhbm5veWluZyB0byByZWFkIGFuZCB1cGRh dGUuCj4KPiBObyBmdW5jdGlvbmFsIGNoYW5nZSBpbnRlbmRlZC4KPgo+IFNpZ25lZC1vZmYtYnk6 IFNlYW4gQ2hyaXN0b3BoZXJzb24gPHNlYW5qY0Bnb29nbGUuY29tPgoKUmV2aWV3ZWQtYnk6IEFs ZXggQmVubsOpZSA8YWxleC5iZW5uZWVAbGluYXJvLm9yZz4KCi0tIApBbGV4IEJlbm7DqWUKVmly dHVhbGlzYXRpb24gVGVjaCBMZWFkIEAgTGluYXJvCgpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1yaXNjdiBtYWlsaW5nIGxpc3QKbGludXgtcmlz Y3ZAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2xpbnV4LXJpc2N2Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BF40FC3DA4A for ; Thu, 1 Aug 2024 09:54:36 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=A39K2ghm; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4WZPSq2sGCz3cW3 for ; Thu, 1 Aug 2024 19:54:35 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=A39K2ghm; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linaro.org (client-ip=2a00:1450:4864:20::52c; helo=mail-ed1-x52c.google.com; envelope-from=alex.bennee@linaro.org; receiver=lists.ozlabs.org) Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [IPv6:2a00:1450:4864:20::52c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4WZPS24Zlgz30TQ for ; Thu, 1 Aug 2024 19:53:52 +1000 (AEST) Received: by mail-ed1-x52c.google.com with SMTP id 4fb4d7f45d1cf-5a2ffc34722so3551482a12.0 for ; Thu, 01 Aug 2024 02:53:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1722506028; x=1723110828; darn=lists.ozlabs.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=8MGDW2w0EUrwnI4S//nT3S+vOipXyZxOwDlAdIY1JMk=; b=A39K2ghmnIbPg7/P02p377vDaTlIkFEQwldrf3MLdmHYbZWvCOMVNQDCUn1Hx+20Wn Kwys838pvWbYpn8PyZeyIfgqTwyt0nLJcDxGeZOmoiZ+dR2ISZp1RrEKCV+moJEVjfwx FPIc/Tv2zXeyAmTZL27T+SHWGOFOCeMbaNAN37l0OuY6fWpxJsJ4mccmBLPNwtxVWsNl tU27ZgL4Cx8IQwr97uTSw2XVN6q4C02bHO5MTOkKHebq5JLc7HbH1FojtVF5f0ONiBD2 XAurUdzGqo26Z3JNtlNdpAvxsWgxPwWsFjzpVAueMJzdyvYFuheIer1zawC4faepjtau 7f2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722506028; x=1723110828; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8MGDW2w0EUrwnI4S//nT3S+vOipXyZxOwDlAdIY1JMk=; b=VS0bwZhNGneUy/bRK81D8u9IZuK9zPMPnITxbSTF5KPTNx+CUuYyVhDi6f6kTJzI0N PCoNwtpPNdOQpe1QzOAQe0dXap9CBXWsh3SAhmMHwSNP0CBNqDjPU4Q6QvWraCLItQpD VKjrrn3x98Kkww1NvXJZKrKXBcUrVCqOhtALenQH8CqMlBnd/nmXvZQjruSxO9Qa3R/D 6+oPIpA5kP3hKGJ4zt2NIvJWf74R8tdM54tclMGBx9urmKBTJjzgK4u94Y7XPBjR1yTP rLVrcgGhwR5YpeVrg28Ugut9oaIjNP0V47QX6/GOHF5JjotvgoSj+cIGnhiaVPPqkZMz f5mQ== X-Forwarded-Encrypted: i=1; AJvYcCWOzRcIy5kpVOyc/GYc4gdPbvxV5vQZW7mZPYTetNph5/qMS0A9PoZ9IjeP40e764Z8edHn4BgLe1Y/nQJKQMrCJ6F94RLfcHo2khjwdQ== X-Gm-Message-State: AOJu0YyQVGJaIPmQ5Bh2T5/RAGL+gJoh6+IsC3HVseJUeE631NdUytl2 tGb+P1d1D9PrPYQS2lRo272RKO92ZTIRIrsNGNk73vaj8MQn2ayDodC8sxpAU/k= X-Google-Smtp-Source: AGHT+IHNrw29WKyolinu6cyXHFfq+0WsM6WXcBxZ1/oFvQaGEtI1aOWo6VY84S/JlZwJgkWdM0qlVw== X-Received: by 2002:a05:6402:440d:b0:57d:5442:a709 with SMTP id 4fb4d7f45d1cf-5b778dc53f8mr879162a12.0.1722506028149; Thu, 01 Aug 2024 02:53:48 -0700 (PDT) Received: from draig.lan ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5b5257f39adsm2866327a12.96.2024.08.01.02.53.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Aug 2024 02:53:41 -0700 (PDT) Received: from draig (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id CC0595F80C; Thu, 1 Aug 2024 10:53:39 +0100 (BST) From: =?utf-8?Q?Alex_Benn=C3=A9e?= To: Sean Christopherson Subject: Re: [PATCH v12 24/84] KVM: Use plain "struct page" pointer instead of single-entry array In-Reply-To: <20240726235234.228822-25-seanjc@google.com> (Sean Christopherson's message of "Fri, 26 Jul 2024 16:51:33 -0700") References: <20240726235234.228822-1-seanjc@google.com> <20240726235234.228822-25-seanjc@google.com> Date: Thu, 01 Aug 2024 10:53:39 +0100 Message-ID: <87le1gefh8.fsf@draig.linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, David Matlack , linux-riscv@lists.infradead.org, Claudio Imbrenda , Janosch Frank , Marc Zyngier , Huacai Chen , Christian Borntraeger , Albert Ou , Bibo Mao , loongarch@lists.linux.dev, Paul Walmsley , kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, Oliver Upton , Palmer Dabbelt , David Stevens , kvm-riscv@lists.infradead.org, Anup Patel , Paolo Bonzini , Tianrui Zhao , linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Sean Christopherson writes: > Use a single pointer instead of a single-entry array for the struct page > pointer in hva_to_pfn_fast(). Using an array makes the code unnecessarily > annoying to read and update. > > No functional change intended. > > Signed-off-by: Sean Christopherson Reviewed-by: Alex Benn=C3=A9e --=20 Alex Benn=C3=A9e Virtualisation Tech Lead @ Linaro